Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rivr thin adapter #5

Merged
merged 15 commits into from
Dec 5, 2018
Merged

Rivr thin adapter #5

merged 15 commits into from
Dec 5, 2018

Conversation

AlessandroDG
Copy link
Member

@AlessandroDG AlessandroDG commented Dec 5, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Delegates the events handling to an external component that Rivr will provide to publishers.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@AlessandroDG AlessandroDG merged commit 970dc93 into master Dec 5, 2018
AlessandroDG pushed a commit that referenced this pull request Jan 8, 2019
* Rivr thin adapter (#5)

* RVR-2049 - change impression event

* RVR-2049 - fix user id value returned on creation of the cookie

* RVR-2049 - remove blockedCategories and browser properties from Auction object

* RVR-2060 - rewrite rendering detection for impression and click events

* RVR-2060 - rewrite tests for rendering detection for impression and click events

* RVR-2049 - send ad unit code in click event

* RVR-2049 - adapt tests for click event

* RVR-2072 - split impression detection depending on the ad server - DFP/none

* RVR-2056 - set creativeId in Auction -> received bids

* RVR-2056 - set bid.clearPrice to cmp

* RVR-2087 - extract trackAuctionInit implementation to rivraddon

* RVR-2087 - extract implementation to rivraddon WIP

* RVR-2087 - extract implementation to rivraddon

* RVR-2087 - extract implementation to rivraddon

* RVR-2087 - Update package-lock

* RVR-2087 - Add addons check

* Rivr Thin Adapter - part 2 (#6)

* RVR-2087 - Remove sendAuction call from ExpiringQueue

* RVR-2147 - Fix test failing on IE 11.0.0

* RVR-2087 - Remove ExpiringQueue
AlessandroDG pushed a commit that referenced this pull request Mar 26, 2019
RVR-1182 report on impression event for each one of the winner Ads

Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant