Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unit test cases #1076

Closed
wants to merge 4 commits into from

Conversation

Arunkumar0610
Copy link
Contributor

@Arunkumar0610 Arunkumar0610 commented Jan 9, 2024

added tests for #1037 #1069
1. SimplCommerce.Module.Core
Services - WidgetInstanceService
2. SimplCommerce.Module.Pricing
Controllers - CartRuleApiController & CartRuleUsageApiController
3. SimplCommerce.Module.ProductComparison
Services - ComparingProductService
Controllers - ComparingProductController
4. SimplCommerce.Module.ShippingFree
Services- FreeShippingServiceProvider

@Arunkumar0610
Copy link
Contributor Author

Hi @hishamco, I have raised the new PR for each test project. #1069

@hishamco
Copy link
Member

hishamco commented Jan 9, 2024

Why not small manageable PRs to make it easier to review

@Arunkumar0610
Copy link
Contributor Author

Arunkumar0610 commented Jan 10, 2024

Hi @hishamco , raised new PRs for each testproject

@hishamco
Copy link
Member

I think this need to be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants