Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release note format #82

Merged
merged 7 commits into from
Feb 10, 2024

Conversation

LitoMore
Copy link
Member

@LitoMore LitoMore commented Feb 7, 2024

I updated the release note format to similar to npm/cli release note.

The benefit is the Contributors section in the release note.

I also removed the core.debug(file). It's too long and super hard to read. We can simply use the GitHub REST API to check specific PR response. Or use our npm run preview script for debugging.

@LitoMore LitoMore added the enhancement New feature or request label Feb 7, 2024
@LitoMore LitoMore requested a review from mondeja February 7, 2024 14:26
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me though I like the @adamrusted's suggestion.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Varying the maintainer names used, to properly demonstrate functionality works.

__mocks__/@actions/github.js Outdated Show resolved Hide resolved
test/create.test.js Outdated Show resolved Hide resolved
test/create.test.js Outdated Show resolved Hide resolved
test/create.test.js Outdated Show resolved Hide resolved
LitoMore and others added 4 commits February 10, 2024 17:13
Co-authored-by: Adam Rusted <hello@adamrusted.me>
Co-authored-by: Adam Rusted <hello@adamrusted.me>
Co-authored-by: Adam Rusted <hello@adamrusted.me>
Co-authored-by: Adam Rusted <hello@adamrusted.me>
@LitoMore LitoMore merged commit bbc49fd into simple-icons:master Feb 10, 2024
3 checks passed
@LitoMore LitoMore deleted the update-release-note-format branch February 10, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants