Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Bricks Builder icon #10022

Merged

Conversation

Mvlprem
Copy link
Member

@Mvlprem Mvlprem commented Dec 4, 2023

bricks

Issue: closes #9710

Similarweb rank: 192,471

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Official svg can be downloaded from their website Media kit

Svg used bricks-favicon-b.svg from the downloaded kit. Hex taken from the logo.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Dec 4, 2023
@adamrusted
Copy link
Member

Thanks for this @Mvlprem!
I think I'd either expect to see some differentiation between the shades of yellow used in the icon or - as used on their website - the b letter in bricks-favicon-b.svg. What are your thoughts on this?

@Mvlprem
Copy link
Member Author

Mvlprem commented Dec 4, 2023

Thanks for this @Mvlprem! I think I'd either expect to see some differentiation between the shades of yellow used in the icon or - as used on their website - the b letter in bricks-favicon-b.svg. What are your thoughts on this?

Hello @adamrusted Actually their logo of blocks is using three different colors(shades) and i just picked this one and i believe this comes closer than others as favicon background.

@adamrusted
Copy link
Member

That's fine on selecting the hex for us to use - but in terms of the icon, given we're a monochrome icon library I'd expect to either see some gaps between the colours in the icon you selected - or we should use the monochrome icon they provided, being the b one I mentioned above :)

@Mvlprem
Copy link
Member Author

Mvlprem commented Dec 4, 2023

That's fine on selecting the hex for us to use - but in terms of the icon, given we're a monochrome icon library I'd expect to either see some gaps between the colours in the icon you selected - or we should use the monochrome icon they provided, being the b one I mentioned above :)

Initially i wanted to go with the b icon too but upon scaling down the icon it becomes 18.73 in width and 24 in height now these dimensions throw linting error like this <path> must be centered at (12, 12); the center is currently (12.367, 12) as for my understanding it's due to decimal points.

or if i add some gaps between the blocks like 0.1dp it's wont be exactly the same when comparing with original is that ok?

@adamrusted
Copy link
Member

Let me take a look at the b path. The linter can be a fickle beast - so we might just need to optimise to a higher precision...

@Mvlprem
Copy link
Member Author

Mvlprem commented Dec 6, 2023

Let me take a look at the b path. The linter can be a fickle beast - so we might just need to optimise to a higher precision...

Hello @adamrusted I've updated the icon to b logo please take a look.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG looks good to me now, @Mvlprem 👍🏻 Just 2 small suggestions for the data and this will be ready to merge.

_data/simple-icons.json Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
@PeterShaggyNoble PeterShaggyNoble merged commit 40ac638 into simple-icons:develop Dec 9, 2023
3 checks passed
@Mvlprem Mvlprem deleted the add-bricks-builder-icon branch December 9, 2023 11:36
mondeja added a commit that referenced this pull request Dec 10, 2023
# New Icons

- Bakal&#225;&#345;i (#10031)
- Bricks (#10022)
- DeepL (#9464)
- Dunzo (#10028)
- Educative (#10036)
- Google Cloud Storage (#9467)
- GrapheneOS (#9281)
- Graphite (#10027)
- Great Learning (#10035)
- Hepsiemlak (#9705)
- Moodle (#10030)
- NETGEAR (#8250)
- Niantic (#9988)
- oclif (#9965)
- Packt (#10038)
- Piapro (#9737)
- Picxy (#9719)
- Resend (#9448)
- Skaffold (#10004)
- Softpedia (#10032)
- Tinkercad (#10033)
- Viblo (#10003)
- Xendit (#9981)

# Updated Icons

- Dassault Systèmes (#8471)
- F-Droid (#10010)
- F-Secure (#10010)
- Flattr (#10010)
- Guangzhou Metro (#10010)
- Lemmy (#10010)
- Lenovo (#10010)
- Monero (#10010)
- MoneyGram (#10010)
- PeerTube (#10010)
- Pegasus Airlines (#10010)
- Pleroma (#10010)
- Reddit (#9964)
- Safari (#9958)
- Write.as (#9884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bricks Builder
3 participants