Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Snort icon #11117

Merged
merged 11 commits into from
Jun 7, 2024
Merged

Add Snort icon #11117

merged 11 commits into from
Jun 7, 2024

Conversation

nicolegrimpeur
Copy link
Contributor

image

Issue: closes #11116

Popularity metric:

The Similarweb rank is 183,833. See https://www.similarweb.com/fr/website/snort.org

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Svg source from : https://icon-icons.com/fr/icone/Snort/131984
Resized it using https://boxy-svg.com/app
And optimised with SVGO
For the color, it is the main color from the original logo : https://www.snort.org/assets/logo_snort_color.svg

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label Jun 5, 2024
@uncenter uncenter changed the title Snort Add Snort icon Jun 5, 2024
uncenter
uncenter requested changes Jun 5, 2024
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
@uncenter

This comment was marked as resolved.

Sign in to view
@nicolegrimpeur
Copy link
Contributor Author

New preview :
image

@uncenter
Copy link
Member

uncenter commented Jun 5, 2024

Make sure you are following all of the steps on https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#4-annotate-the-icon. You are missing the <title> element and maybe more.

@nicolegrimpeur
Add title to SVG and correct official source link
01ae6b5 
For the link, corrected as asked by the npm run lint
@nicolegrimpeur
Copy link
Contributor Author

You're right, should be better now 👌

uncenter
uncenter requested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@uncenter uncenter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-06-06 at 13 02 39 (Inkscape)

I'm not seeing the original line up with yours? Make sure not to stretch the logo to fit - you only want/need two of the sides to touch, which means locking the aspect ratio and setting whichever is higher between the width and height to 24.

@uncenter
Copy link
Member

uncenter commented Jun 6, 2024

Also where did you find the https://www.snort.org/assets/logo_snort_color.svg from? I can't see it displayed anywhere on the website.

@nicolegrimpeur
Copy link
Contributor Author

I think I unintentionally streched the image while I was shrinking it. I am go try again and pay attention to this point
The logo come from this page : https://www.snort.org/community
It is the illustration for the link to the blog

@nicolegrimpeur
Copy link
Contributor Author

Here is the new preview (same svg, should be not streched now)
image
I made a bit like last time by downloading the source svg and removed the colored element, but I have done the resized directly in illustrator to keep the proportion so it should be good now

adamrusted
adamrusted approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @nicolegrimpeur 🎉

@adamrusted adamrusted merged commit 47a6235 into simple-icons:develop Jun 7, 2024
3 checks passed
@simple-icons simple-icons bot mentioned this pull request Jun 9, 2024
Merged
simple-icons bot added a commit that referenced this pull request Jun 9, 2024
@simple-icons
Release 16 new icons and 2 updated icons (v12.2.0)
0607325 
# New Icons

- 1Panel (#10484) (@yhmyhm0910)
- 2FAS (#11071) (@anhthang)
- Aegis Authenticator (#11039) (@CodeShakingSheep)
- Asterisk (#11111) (@uncenter)
- Astral (#11099) (@uncenter)
- Bambu Lab (#11009) (@RaghavMaliwal)
- Eraser (#11056) (@anhthang)
- Formik (#11063) (@CodeShakingSheep)
- Geode (#10822) (@uncenter)
- LangChain (#11100) (@uncenter)
- NiceHash (#11075) (@anhthang)
- ntfy (#11115) (@anhthang)
- remove.bg (#11121) (@anhthang)
- Snort (#11117) (@nicolegrimpeur)
- VEED (#11106) (@uncenter)
- visx (#11102) (@uncenter)

# Updated Icons

- DeepL (#11125) (@uncenter)
- Firebase (#11131) (@adamrusted)
@nicolegrimpeur
Copy link
Contributor Author

LGTM! Thanks @nicolegrimpeur 🎉

Thank you! And thanks a lot to @uncenter for all the informations and his time to help me on this!

@uncenter
Copy link
Member

uncenter commented Jun 9, 2024

Happy to help! Thanks again for your contribution ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uncenter uncenter uncenter requested changes

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Snort
3 participants
@nicolegrimpeur @uncenter @adamrusted