Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No additional labeling nor project assigning for release pull requests #11153

Merged

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Jun 9, 2024

We started adding new icon Issues or pull requests for adding a new icon and update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both labels to release pull requests in #10785 (see here). After some digging, I think that the change was introduced by #10726, but I'm not sure.

Anyways, if we're targetting master base ref we don't need to assign to a project nor add labels to that pull request because we can assume that is a special pull request.

When this PR is merged I'll remove those labels of the release pull requests for previous releases.

@mondeja mondeja requested a review from LitoMore June 9, 2024 10:25
@simple-icons simple-icons bot added the meta Issues or pull requests regarding the project or repository itself label Jun 9, 2024
@adamrusted adamrusted merged commit 858ad8c into simple-icons:develop Jun 9, 2024
7 checks passed
@mondeja mondeja removed the request for review from LitoMore June 9, 2024 10:41
@mondeja mondeja deleted the release-no-additional-labels branch June 9, 2024 10:41
@LitoMore
Copy link
Member

LitoMore commented Jun 9, 2024

I'll remove those labels of the release pull requests for previous releases.

@mondeja Updating merged PRs may cause an issue with the inconsistent release note.

@mondeja
Copy link
Member Author

mondeja commented Jun 9, 2024

I've removed all labels from previous release Pull requests that released a new version pull requests except the release Pull requests that released a new version one. That issue happens with pull requests that has not been included in the last release, which are the ones that the release action uses to generate the release note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants