Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PostCSS icon (#2758) #2759

Merged
merged 5 commits into from
Mar 9, 2020
Merged

Add PostCSS icon (#2758) #2759

merged 5 commits into from
Mar 9, 2020

Conversation

phatbhoy67
Copy link
Contributor

postcss

Issue: Close #2758

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Source is official svg found in the front page of the PostCSS website.

Hex value #DD3A0A is from the svg.

@PeterShaggyNoble
Copy link
Member

This is coming in a 24.001 wide, @phatbhoy67, and it's also missing some of the detail from the 3rd path in the original (the white bits in the 12x comparison below).

PostCSS

@PeterShaggyNoble PeterShaggyNoble added changes requested new icon Issues or pull requests for adding a new icon labels Mar 9, 2020
@phatbhoy67
Copy link
Contributor Author

Hey @PeterShaggyNoble, think I have fixed both issues now.

@PeterShaggyNoble
Copy link
Member

I think you might need to up the precision on it as well, @phatbhoy67 - I'm seeing some small differences in some of the finer detail. For example, from the bottom of the triangle's left edge (original in black):

image

There's also a very thin line running through the bottom right quarter, which is also present in the original, that we might want to fix:

image

@phatbhoy67
Copy link
Contributor Author

Line removed @PeterShaggyNoble and precision 4.
postcss (1)

@PeterShaggyNoble
Copy link
Member

SVG looks spot on to me now, @phatbhoy67 - nice work 👍

Although, when I open it, it's not on the canvas. Could be Inkscape playing silly-buggers on me but I'll let one of the other @simple-icons/maintainers throw an eye over it just in case.

@PeterShaggyNoble
Copy link
Member

Restarted Inkscape and all is fine now so gonna go ahead and merge this in.

@PeterShaggyNoble PeterShaggyNoble merged commit 09e8f6d into simple-icons:develop Mar 9, 2020
@phatbhoy67 phatbhoy67 deleted the postcss branch March 9, 2020 18:02
@ericcornelissen ericcornelissen mentioned this pull request Mar 15, 2020
Merged
ericcornelissen added a commit that referenced this pull request Mar 16, 2020
@ericcornelissen
Merge pull request #2788 from simple-icons/develop
eb60aaf 
# New icons

- Bosch (#2661)
- Ulule (#2714)
- Shopware (#2698)
- Castbox (#2715)
- Plus Codes (#2717)
- Vauxhall (#2647)
- freedesktop.org (#2730)
- ESLGaming (#2731)
- BBC iPlayer (#2739)
- Transport for London (#2742)
- Gatling (#2741)
- Farfetch (#2750)
- Helly Hansen (#2747)
- Roku (#2751)
- Android Auto (#2542)
- Ford (#2632)
- Contactless Payment (#2584)
- TeamSpeak (#2700)
- Microsoft SharePoint (#2555)
- PagSeguro (#2683)
- Microsoft Visio (#2645)
- Microsoft Exchange (#2621)
- Puppet (#2694)
- vBulletin (#2721)
- PostCSS (#2759)
- AdBlock (#2761)
- HBO (#2760)
- Apple TV (#2736)
- Dash (#2728)
- Clyp (#2725)
- Vivaldi (#2724)
- iBeacon (#2729)
- Google AdSense (#2597)
- Badgr (#2768)
- Wikimedia Commons (#2685)
- ProSieben (#2627)
- Hyundai (#2641)
- Honda (#2642)
- Mazda (#2643)
- Nissan (#2649)
- Renault (#2651)
- Windows XP (#2653)
- ASKfm (#2608)
- Lubuntu (#2644)
- McDonald's (#2706)
- Eclipse Mosquitto (#2718)
- Bitwarden (#2719)
- Alfa Romeo (#2744)
- Adobe Fonts (#2776)
- ŠKODA (#2657)
- Bugatti (#2745)
- libuv (#2720)
- Volvo (#2755)
- A-Frame (#2763)
- Car Throttle (#2773)
- OpenStack (#2772)
- Adblock Plus (#2726)
- WWE (#2612)
- Phabricator (#2716)
- Toyota (#2746)
- Egnyte (#2723)
- Warner Bros (#2704)
- MAN (#2774)
- App Store (#2611)
- Chupa Chups (#2668)
- Google Calendar (#2743)
- Scania (#2775)
- niconico (#2614)
- Fiat (#2652)
- WEMO (#2619)
- Nintendo Network (#2780)
- UpLabs (#2781)
- WebMoney (#2782)

# Updated icons

- Google Maps (#2663)
- Yammer (#2558)
- Expo (#2594)
- T-mobile (#2757)
- Adobe Photoshop (#2733)
- BMW (#2737)
- Chase (#2722)
- Riot (#2732)
- Redis (#2677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcornelissen ericcornelissen Awaiting requested review from ericcornelissen

@runxel runxel Awaiting requested review from runxel

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PostCSS
2 participants
@phatbhoy67 @PeterShaggyNoble