Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ask Ubuntu #5148

Merged
merged 6 commits into from
Apr 28, 2021
Merged

Add Ask Ubuntu #5148

merged 6 commits into from
Apr 28, 2021

Conversation

alagos
Copy link
Contributor

@alagos alagos commented Mar 1, 2021

askubuntu

Issue: Closes #5095
Alexa rank: ~3012

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

No media kit found, but I used this svg as base (Logo located in the header of askubuntu.com), then I cropped it to fit only the "ask" logo.
#dc461d used, as it was suggested in the original ticket.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 1, 2021
@PeterShaggyNoble
Copy link
Member

Welcome to Simple Icons, @alagos and thanks for taking this one on 👍

Everything looks pretty good to me. However, before we merge it, could you see if you could clean up some of the points in the lettering?

@alagos
Copy link
Contributor Author

alagos commented Mar 3, 2021

@PeterShaggyNoble with that you meant to tick all the checklist? because I already optimized the file, I just forgot to tick it (now is done)

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submit this pull @alagos 👍🏻

_data/simple-icons.json Outdated Show resolved Hide resolved
@PeterShaggyNoble
Copy link
Member

Sorry, @alagos, should have been clearer on that: the letters in the source file consist of more points than are necessary (see below), which we should try to clean up if at all possible. This is as a result of them originally having been a text element that was later converted to a path. I'm unsure, though, if it's a software specific thing or just particular to Inkscape so, if you're using something else, it may be easier to install this font and use the SVG @service-paradis found here as a starting point, rather than trying to fix the version from their website manually.

@PeterShaggyNoble
Copy link
Member

Took a run at cleaning this up myself but it turns out that Inkscape's "Simplify path" tool actually means "Butcher it mercilessly" and trying to do it manually, before or after simplification, is just insanity!

So, unless someone else can do a better job or recreate it from scratch, I say we merge this in as-is for now.

@alagos
Copy link
Contributor Author

alagos commented Apr 26, 2021

@mondeja guidelines added

@PeterShaggyNoble
Copy link
Member

Thanks, @alagos. As quite some time has passed with nobody offering an improvement with regard to the number of points in the lettering, I'm going to merge this in as it is and if anyone can clean it up in the future then we can address that in a separate PR.

@PeterShaggyNoble PeterShaggyNoble merged commit 464b1d2 into simple-icons:develop Apr 28, 2021
ericcornelissen added a commit that referenced this pull request May 2, 2021
# New Icons

- Ask Ubuntu (#5148)
- Roblox (#5497)
- Rocket.Chat (#5190)
- ScrollReveal (#5211)
- Tekton (#5445)

# Updated Icons

- Flickr (#5500)
- Let's Encrypt (#5529)
- Pagekit (#5398)
- PagerDuty (#5398)
- pandas (#5398)
- Pantheon (#5398)
- Parse.ly (#5398)
- Patreon (#5398)
- PCGamingWiki (#5398)
- PeerTube (#5398)
- Pelican (#5398)
- Pepsi (#5398)
- Periscope (#5398)
- Phillips Hue (#5398)
- PHP (#5398)
- Pi-hole (#5398)
- Pimcore (#5398)
- Pingdom (#5398)
- Pinterest (#5398)
- Pivotal Tracker (#5398)
- pixiv (#5398)
- PJSIP (#5398)
- PlanGrid (#5398)
- PlayStation (#5398)
- Plesk (#5398)
- Plex (#5398)
- Plurk (#5398)
- Pocket (#5398)
- Polymer Project (#5398)
- PostgreSQL (#5398)
- POWERS (#5398)
- pre-commit (#5398)
- Prettier (#5398)
- Prime (#5398)
- Prime Video (#5398)
- Probot (#5398)
- ProcessWire (#5398)
- Product Hunt (#5398)
- Progress (#5398)
- protocols.io (#5398)
- Proxmox (#5398)
- Publons (#5398)
- PureScript (#5398)
- Python (#5398)
- PyTorch (#5398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Ask Ubuntu icon
3 participants