-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Plausible Analytics #5151
Add Plausible Analytics #5151
Conversation
thanks @PeterShaggyNoble! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing some minor differences in the cutout between your version and the original that maybe are caused by the optimization process. Could you check that @PeterShaggyNoble?
@mondeja, you need to remove the |
Yep, that's true, thank you for the correction 🤦♂️ I'm fine with the geometry, but could you explain why the top part of the cut is so smooth (your version red, source blue). Wouldn't it not be better to stick closer to the original path? |
I assumed the fact that the circle overlaps the "P" shape in a number of places was a mistake in the original. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you explain why the top part of the cut is so smooth
I assumed the fact that the circle overlaps the "P" shape in a number of places was a mistake in the original.
I'm inclined to agree with Peter here. In the interest of getting this off the backlog I will merge this now (provided the CI doesn't fail). We can always revisit the curvature on this one later.
Issue: Closes #4878
Alexa rank: ~51.9k
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Icon treatment approved by co-founder @metmarkosaric in original issue.
Not as easy an icon to work on as it first appeared so may be improvable. Colour from website styleseheet.