Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plausible Analytics #5151

Merged

Conversation

PeterShaggyNoble
Copy link
Member

Plausible Analytics

Issue: Closes #4878
Alexa rank: ~51.9k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon treatment approved by co-founder @metmarkosaric in original issue.

Not as easy an icon to work on as it first appeared so may be improvable. Colour from website styleseheet.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Mar 2, 2021
@metmarkosaric
Copy link

thanks @PeterShaggyNoble!

mondeja
mondeja previously requested changes Mar 7, 2021
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some minor differences in the cutout between your version and the original that maybe are caused by the optimization process. Could you check that @PeterShaggyNoble?

image

@PeterShaggyNoble
Copy link
Member Author

@mondeja, you need to remove the rect in the source SVG before resizing it; the icon is slightly smaller than it so you'll see that difference when comparing without removing the rect.

@mondeja
Copy link
Member

mondeja commented Mar 8, 2021

Yep, that's true, thank you for the correction 🤦‍♂️

I'm fine with the geometry, but could you explain why the top part of the cut is so smooth (your version red, source blue). Wouldn't it not be better to stick closer to the original path?

@mondeja mondeja added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Mar 8, 2021
@PeterShaggyNoble
Copy link
Member Author

could you explain why the top part of the cut is so smooth

I assumed the fact that the circle overlaps the "P" shape in a number of places was a mistake in the original.

@PeterShaggyNoble PeterShaggyNoble removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Mar 16, 2021
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you explain why the top part of the cut is so smooth

I assumed the fact that the circle overlaps the "P" shape in a number of places was a mistake in the original.

I'm inclined to agree with Peter here. In the interest of getting this off the backlog I will merge this now (provided the CI doesn't fail). We can always revisit the curvature on this one later.

@ericcornelissen ericcornelissen merged commit 7a9e400 into simple-icons:develop Jul 17, 2021
@github-actions github-actions bot mentioned this pull request Jul 18, 2021
ericcornelissen added a commit that referenced this pull request Jul 18, 2021
# New Icons

- Civo (#6065)
- Douban Read (#6084)
- Plausible Analytics (#5151)
dirien pushed a commit to dirien/simple-icons that referenced this pull request Jul 20, 2021
@PeterShaggyNoble PeterShaggyNoble deleted the add/plausibleanalyics branch August 13, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Plausible Analytics
4 participants