-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Icinga #5195
Add Icinga #5195
Conversation
Well, I think I will fix the icon size from 23.998 x 24.002 to exactly 24 x 24 😄 |
@rafi0101 Note: The icon should only be exactly 24x24px if the original icon is a perfect square. Otherwise (in most cases) the icon has to be scaled so that either the width OR the height is 24px - whichever is bigger. |
@fbernhart Now you can have a look at it. I think the icon is ready. |
The dimensions of this still seem to be off when compared to the original, @rafi0101; would you mind having another look? The width should be about |
Oh, and for the colour, I'd suggest |
Yes, I'll have a look at it.
Maybe @PeterShaggyNoble can you provide me your source, because I can't find anything to this topic. |
It's the colour used for the overall page background on their website. |
@PeterShaggyNoble now I think this svg is ready. I opened the original svg in inkscape and changed the hight to 24 in locked mode, so the proportions should fit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes later, I think it is ready 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rafi0101 - though there are now a fair few differences on the circles. This can be down to SVGO, so you may need to up the precision to 4. Would you mind rebuilding this one and trying a precision of 4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still a couple of small differences, which you may be able to tweak just by moving the points around in your editor - but otherwise the 4 decimals seem to have fixed it 💪
@adamrusted how do you compare my svg to the original? Also is there a tool I can use that I can check it myself? |
I'm just pulling your PR and the original source icon (scaled, but not optimized on my end) into the same Illustrator / Affinity file, overlaying yours in a bright colour with some opacity. |
Thanks for this info. But I can not fix these small differences. After SVGO these differences are back again, even with precision 7 |
No worries, I'll try and fix them on my end, but will need another maintainer to sign off on the PR in that case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How strange! Pulling this existing path into Illustrator removes the issue completely. Will merge this one, and it'll be released next Sunday. Thanks for your work @rafi0101 🚀
Strange. I used Inkscape to edit the svg. Maybe it was the program or just me. However, thanks for the effort @adamrusted 💪. |
Issue: Resolves #5132
Alexa rank: 262,337
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
I used this SVG from IcingaWeb2.