Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PayPal #5467

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Updated PayPal #5467

merged 2 commits into from
Apr 21, 2021

Conversation

adamrusted
Copy link
Member

paypal

Issue: Contributes to #5398.
Alexa rank:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Updated source to PayPal homepage. Used SVG at source and cut gap between the two paths.

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Apr 16, 2021
@PeterShaggyNoble
Copy link
Member

Treatment looks good to me, @adamrusted. Just one small difference in the bottom "P", at the top of the cut-out which should be fixable by dragging the corner point in yours up to meet the curve of the original.

Also, looking at the products shots here it looks to me like the cut-out should be outside rather than inside the bottom "P". What do you think?

@adamrusted
Copy link
Member Author

adamrusted commented Apr 20, 2021

Just one small difference in the bottom "P", at the top of the cut-out

Will fix this now 👍

Also, looking at the products shots here it looks to me like the cut-out should be outside rather than inside the bottom "P". What do you think?

I think they've got a stylized monochrome logo that they're not sharing! Only way I could recreate that using the current SVG source would be to carry on the cut-out to the bottom of the bottom "P" - but that may look a bit odd.

That icon also doesn't have the rounded corners of their primary logo - so I think we can discount that (unless we can find an official source)

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks perfect to me now, @adamrusted, nice one 👍🏻

I was so focused on the cut-out in the version one their card reader I hadn't noticed the other differences in it so, yeah, it looks like it's been stylised specifically for that purpose - just eyeballing it from the photos, it looks like the top "P" has been moved slightly further away from the bottom one.

@PeterShaggyNoble PeterShaggyNoble merged commit 9d7dfcb into simple-icons:develop Apr 21, 2021
@adamrusted adamrusted deleted the Update/PayPal branch April 21, 2021 15:46
ericcornelissen added a commit that referenced this pull request Apr 25, 2021
# New Icons

- Automattic (#5489)
- Datto (#5493)
- FamPay (#5505)
- Forestry (#5454)
- Immer (#5437)
- KashFlow (#5465)
- Kdenlive (#5193)
- LIFX (#5448)
- Photopea (#5518)
- pnpm (#5482)

# Updated Icons

- Gitpod (#5464)
- IBM (#5496)
- IBM Watson (#5496)
- ICON (#5496)
- Iconfinder (#5496)
- iDEAL (#5496)
- IEEE (#5496)
- iFixit (#5496)
- iFood (#5496)
- IFTTT (#5496)
- iHeartRadio (#5496)
- IKEA (#5496)
- IMDb (#5496)
- Imgur (#5496)
- Imou (#5496)
- Indeed (#5496)
- Infiniti (#5496)
- InfluxDB (#5496)
- Informatica (#5496)
- Infosys (#5496)
- Ingress (#5496)
- Inkscape (#5496)
- Insomnia (#5496)
- Instagram (#5496)
- Instapaper (#5496)
- Intel (#5496)
- IntelliJ IDEA (#5496)
- Intercom (#5496)
- Internet Archive (#5496)
- Internet Explorer (#5496)
- Invoice Ninja (#5496)
- ioBroker (#5496)
- Ionic (#5496)
- Issuu (#5496)
- Itch.io (#5496)
- PayPal (#5467)
- Plus Codes (#5468)
- R (#5285)
- Zotero (#5491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants