Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter H review #5555

Merged
merged 22 commits into from
May 4, 2021
Merged

Letter H review #5555

merged 22 commits into from
May 4, 2021

Conversation

service-paradis
Copy link
Member

@service-paradis service-paradis commented Apr 27, 2021

Issue: #5251

Notes

- Add guidelines
- Update source
- Update hex
- Update source
- Add guidelines
- Update source
- Add guidelines
- Update hex
- Update source
- Update source
- Add guidelines
- Add guidelines
- Add guidelines
- Update source
- Update source
- Add guidelines
- Update source
- Add guidelines
- Update source
- Add license
- Update source
- Update source
- Add guidelines
- Add guidelines
- Update source
- Add guidelines
- Add guidelines
- Update hex
- Update source
- Add guidelines
- Update source
- Add guidelines
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do you want to break the updates out into their own issues so we can get this merged in?

@service-paradis
Copy link
Member Author

LGTM! Do you want to break the updates out into their own issues so we can get this merged in?

Done :)
Except for the 2 icons where I cannot find better source for now. Since they dont necessarily need to be updated, we might keep the new sources and update them if we find something in the future. What do you think?

@adamrusted
Copy link
Member

Since they dont necessarily need to be updated, we might keep the new sources and update them if we find something in the future. What do you think?

I think we're okay to merge this without worrying about those for now. No doubt they'll get flagged again in the future, either when a rebrand takes effect (and hopefully, a new source is found at that point) or they re-vamp their website giving us the relevant files. Until then, if they're not outdated - I feel we're safe to ignore them.

@adamrusted adamrusted merged commit dd852e4 into simple-icons:develop May 4, 2021
@service-paradis service-paradis deleted the h-review branch May 4, 2021 12:13
ericcornelissen added a commit that referenced this pull request May 9, 2021
# New Icons

- Adafruit (#5592)
- Alpine.js (#5607)
- BookBub (#5435)
- FFmpeg (#5537)
- Google Fonts (#5207)
- IOTA (#5520)
- Lit (#5571)
- Odysee (#5577)
- ONNX (#5472)
- OpenWrt (#5576)
- Purism (#5462)
- Pusher (#5568)
- Telegraph (#5501)
- Thingiverse (#5591)
- UFC (#5569)

# Updated Icons

- Ford (#5564)
- Hack The Box (#5555)
- Hackaday (#5555)
- HackHands (#5555)
- Hackster (#5555)
- Handshake (#5555)
- Handshake (#5555)
- Harbor (#5555)
- Hashnode (#5555)
- Haskell (#5555)
- Hasura (#5555)
- Haxe (#5555)
- HBO (#5555)
- HCL (#5555)
- Headspace (#5555)
- HelpDesk (#5555)
- HERE (#5555)
- Heroku (#5555)
- Hexo (#5555)
- Hilton (#5555)
- HipChat (#5555)
- HockeyApp (#5555)
- Home Assistant (#5555)
- Home Assistant Community Store (#5555)
- HomeAdvisor (#5555)
- Homebrew (#5555)
- Hootsuite (#5555)
- Hoppscotch (#5555)
- Houzz (#5555)
- HP (#5555)
- Huawei (#5555)
- HubSpot (#5555)
- Hugo (#5555)
- Hulu (#5555)
- Humble Bundle (#5555)
- Hypothesis (#5555)
- Hyundai (#5555)
- ICON (#5519)
- Transport for Ireland (#5621)
- Transport for London (#5621)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants