-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added FMOD Icon #5720
Added FMOD Icon #5720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @made-indrayana, and welcome to Simple Icons! 🎉
Just taking a look at this, it appears there are some differences between your PR in red, and the source in black.
They look to be purely from the optimization, so you may be able to fix them by re-optimizing the source icon to a precision of 4 (either using the slider on SVGOMG, or editing svgo.config.js
within the repo). Would you mind taking another look at it? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now, thanks @made-indrayana!
I'll ping the other @simple-icons/maintainers as there's a slight difference to the ® symbol, but as it's not the brand icon itself, I think we can let it slide. Once I get the okay from someone else, we can get this merged in for release on Sunday!
Thank you so much @adamrusted ! 🙇 |
Damn, mistakenly renamed the branch to something else and this broke the pull request. So sorry, @adamrusted , should I make a new one or this one is still good? |
Agreed; I think we can stop worrying about trademark symbols lining up perfectly, especially if it can save us a precision point; the important thing is merely that they are present. And that they even include it in their favicon themselves means we should probably also include it. So gonna merge this in based on Adam's approval above. Thanks for the contribution, @made-indrayana and welcome to Simple Icons 🙂 |
Perhaps we should look at having a 'stock' ® symbol that is already optimized for our use 'on file' to easily swap in if the brand one isn't up to scratch? 🤔 |
Thank you @PeterShaggyNoble and @adamrusted, I will be very happy to continue to contribute, especially for audio softwares! |
# New Icons - Betfair (#5727) - Chai (#5222) - FMOD (#5720) - ImageJ (#5494) - Intigriti (#5733) - MicroPython (#5681) - Perforce (#5724) - Spring Boot (#5687) - tqdm (#5699) - Weblate (#5688) - Wwise (#5722) # Updated Icons - Azure Pipelines (#5248) - Coinbase (#5712) - FreeBSD (#5701) - G2A (#5703) - GeeksforGeeks (#5704) - Geocaching (#5702) - Ghost (#5739) - Habr (#5713) - Hackster (#5735) - Helly Hansen (#5737) - IBM (#5740) - IMDb (#5700) - Infosys (#5742) - Nubank (#5734) - PostgreSQL (#5715) - Power BI (#5716) - Viadeo (#5260)
Issue: #5709
Alexa rank: 311,101
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
I used the official source here, but I think when displayed as a small icon, it is almost not readable. But it is also the case in their website as favicon. Is this ok or do you have any better suggestion?