-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PaddyPower icon #5744
Added PaddyPower icon #5744
Conversation
You were too quick for me! 😆 Went looking for a vector version of their icon as soon as I saw your issue and, by the time I got back, you had the PR in already. Found this sprite in the source of their main site which includes a couple of versions of the "PP." icon. Would you mind taking another go at it using that SVG instead? Thanks for the contribution, by the way 🙂 |
I started to work at the icon before I added the issue 😅
Yeah I can take a look on those too, maybe we will see some improvements. IMO the one I added looks good.
No worries, I use lots of things from https://shields.io/ for some of our projects, and the icons come from here. It's the least I can do as a thanks for making this awesome opensource project. |
Okay, changed it a bit, tbh I can't see much difference. Updated the preview as well. |
Have you managed to look over it @PeterShaggyNoble ? |
Sorry for the delay, @iugabogdan, been a hectic week getting everything prepped for the release of v5 and launch of the new website this weekend. Which version of the icon is your SVG based on? I'm seeing some differences when comparing it against both versions in the sprite I linked above, with yours in red, the Paddy Power Bingo one in black and the Paddy Power Games one in grey - although given that the dot in the Games one is a square, I think we can rule out using it. Also, if you did base your version on that sprite, could you update the |
Hey @PeterShaggyNoble, I used this one from what I remember, the one with the dot. Tbh I've no idea what I've done, I'm like this dog when it comes to svgs. I just click on buttons in inkscape and hope for the best. Not sure how you got that difference, I can try again cuz definitely I've did something wrong. |
After few google searches, I did it again, it should be ok now! Not sure however why the Lint fails. Thanks |
Ran the linter on my machine and everything is fine.. |
Hey @iugabogdan - looks like the main issue with the linter is part of the v5 update. As part of this week's release, we've removed the requirement for you to include 'icon' in the |
33d9242
to
d6ddfb9
Compare
Hey @adamrusted, I rebased and deleted the title and now I get this. |
9b60c40
to
d15b24e
Compare
@adamrusted @PeterShaggyNoble hey guys seems that everything is alright now. Can you please have a look when you have time ? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 👍 Thanks, @iugabogdan.
Issue: Closes #5743
Alexa rank: 25,784
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
I got the hex value from the header of https://paddypower.com
I got the icon from https://arspp.cdnppb.net/pp-ssc/ssc-sprite.svg