Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PaddyPower icon #5744

Merged
merged 3 commits into from
Jun 3, 2021

Conversation

iugabogdan
Copy link
Contributor

@iugabogdan iugabogdan commented May 19, 2021

paddypower (3)

Issue: Closes #5743
Alexa rank: 25,784

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I got the hex value from the header of https://paddypower.com
I got the icon from https://arspp.cdnppb.net/pp-ssc/ssc-sprite.svg

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label May 19, 2021
@PeterShaggyNoble
Copy link
Member

You were too quick for me! 😆 Went looking for a vector version of their icon as soon as I saw your issue and, by the time I got back, you had the PR in already.

Found this sprite in the source of their main site which includes a couple of versions of the "PP." icon. Would you mind taking another go at it using that SVG instead?

Thanks for the contribution, by the way 🙂

@iugabogdan
Copy link
Contributor Author

You were too quick for me! 😆 Went looking for a vector version of their icon as soon as I saw your issue and, by the time I got back, you had the PR in already.

I started to work at the icon before I added the issue 😅

Found this sprite in the source of their main site which includes a couple of versions of the "PP." icon. Would you mind taking another go at it using that SVG instead?

Yeah I can take a look on those too, maybe we will see some improvements.

IMO the one I added looks good.

Thanks for the contribution, by the way 🙂

No worries, I use lots of things from https://shields.io/ for some of our projects, and the icons come from here. It's the least I can do as a thanks for making this awesome opensource project.

@iugabogdan
Copy link
Contributor Author

Okay, changed it a bit, tbh I can't see much difference. Updated the preview as well.

@iugabogdan
Copy link
Contributor Author

Have you managed to look over it @PeterShaggyNoble ?

@PeterShaggyNoble
Copy link
Member

Sorry for the delay, @iugabogdan, been a hectic week getting everything prepped for the release of v5 and launch of the new website this weekend.

Which version of the icon is your SVG based on? I'm seeing some differences when comparing it against both versions in the sprite I linked above, with yours in red, the Paddy Power Bingo one in black and the Paddy Power Games one in grey - although given that the dot in the Games one is a square, I think we can rule out using it.

Also, if you did base your version on that sprite, could you update the source to the main website, please?

@iugabogdan
Copy link
Contributor Author

Hey @PeterShaggyNoble, I used this one from what I remember, the one with the dot.

image

Tbh I've no idea what I've done, I'm like this dog when it comes to svgs. I just click on buttons in inkscape and hope for the best.

image

Not sure how you got that difference, I can try again cuz definitely I've did something wrong.

@iugabogdan
Copy link
Contributor Author

iugabogdan commented May 28, 2021

Hey @PeterShaggyNoble

After few google searches, I did it again, it should be ok now!

Not sure however why the Lint fails.

Thanks

@iugabogdan
Copy link
Contributor Author

Ran the linter on my machine and everything is fine..

@adamrusted
Copy link
Member

Hey @iugabogdan - looks like the main issue with the linter is part of the v5 update. As part of this week's release, we've removed the requirement for you to include 'icon' in the <title> of the SVG. If you are able to remove that, and perhaps rebase your PR to our current develop branch - this should succeed!

@iugabogdan
Copy link
Contributor Author

Hey @adamrusted, I rebased and deleted the title and now I get this.

image

@iugabogdan
Copy link
Contributor Author

@adamrusted @PeterShaggyNoble hey guys seems that everything is alright now.

Can you please have a look when you have time ?

Thanks!

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍 Thanks, @iugabogdan.

@PeterShaggyNoble PeterShaggyNoble merged commit 565505e into simple-icons:develop Jun 3, 2021
ericcornelissen added a commit that referenced this pull request Jun 6, 2021
# New Icons

- Construct 3 (#5515)
- Paddy Power (#5744)

# Updated Icons

- ManageIQ (#5165)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Request: Paddy Power icon
3 participants