-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Istio icon #6093
Add Istio icon #6093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SVG looks spot on (even with this low precision), nice work @swarup4741!
Before we can merge this in though, I have two requests:
- Can you revert the change the
package-lock.json
? - If you used the SVG linked in the issue as source material, could you update the
"source"
to"https://github.com/istio/istio/blob/5a047251817eb2523af297607b7614120812e47a/logo/istio-bluelogo-whitebackground-unframed.svg"
? Else, could you elaborate on where exactly on the website you found the SVG and why you chose it over this one?
Thank you for updating the source @swarup4741. However, it looks like the changes to Also, I didn't catch this the first time around, but where exactly did you get the color hex value from? The SVG in the source has |
I got the hex the value by using a color picker tool... shall I update the hex value ? |
Using the color picker tool on the source SVG? Or on something else? From the source SVG I'm getting |
No more worries.. i updated the hex to |
In that case the hex value seems fine (it's always possible to change this later if someone disagrees) - the only thing left to do is revert the changes of the As an aside, there's no need to merge |
I have changed the |
My apologies, the GitHub interface says there's 3 changed files so I assumed you didn't change anything yet 😅 Though you did revert most of the changes, you did end up changing (somehow) some of the whitespace in that file. Could you revert those changes as well? (Just to keep our commit history clean.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the white-spaces....
As you can see in the GitHub UI there are still changes between If you want I can take care of this and merge this in for you 🙂 If you want to give it another try, make sure you are copying the content of |
I’ll give it another try … if this time if i’m unable to fix it (somehow) then you please kindly take over and make it happen … I’ll make the changes tomorrow.. (thank you for guiding so much … I’m learning a lot) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll give it another try … if this time if i’m unable to fix it (somehow) then you please kindly take over and make it happen … I’ll make the changes tomorrow.. (thank you for guiding so much … I’m learning a lot)
Almost did it, just one final newline missing in package-lock.json
- fixed that one for you 🙂
Thanks for working on this one @swarup4741 🎉
* Added a new icon * Updated the hex value
# New Icons - DPD (#5831) - Dungeons & Dragons (#5837) - Grab (#6086) - Istio (#6093) - Packer (#5649) - Windi CSS (#6103) # Updated Icons - arXiv (#5884) - Douban (#6114) - Douban Read (#6114) - S7 Airlines (#6147) - Salesforce (#6147) - Samsung (#6147) - Samsung Pay (#6147) - Sass (#6147) - Scaleway (#6147) - Scania (#6147) - Scribd (#6147) - Sencha (#6147) - SEPA (#6147) - Shazam (#6147) - Shopify (#6147) - Shutterstock (#6147) - Sketch (#6147) - Slack (#6147) - SmartThings (#6147) - Snapchat (#6147) - Snapcraft (#6147) - Snowflake (#6147) - Solidity (#6147) - SonarLint (#6147) - SonarQube (#6147) - SonarSource (#6147) - Songkick (#6147) - Songoda (#6147) - Sourcegraph (#6147) - Spacemacs (#6147) - SparkPost (#6147) - Spotify (#6147) - Spreaker (#6147) - Squarespace (#6147) - Stackbit (#6147) - StackPath (#6147) - Starling Bank (#6147) - STARZ (#6147) - Statamic (#6147) - Steam (#6147) - Steinberg (#6147) - Stellar (#6147) - Streamlit (#6147) - Stylus (#6147) - Sublime Text (#6147) - Sumo Logic (#6147) - SurveyMonkey (#6147) - SUSE (#6147) - SVG (#6147) - Symfony (#6147) - Synology (#6147)
Issue: #6090
Alexa rank: 88,863
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
added the istio icon and added the metadata to
_data/simple-icons.json
with hex value466AB1
as provided in issue #6090 and also fixed some linting issues as well.