Add Istio icon #6093

swarup4741 · 2021-07-09T19:29:57Z

Issue: #6090
Alexa rank: 88,863

Checklist

I updated the JSON data in _data/simple-icons.json
I optimized the icon with SVGO or SVGOMG
The SVG viewbox is 0 0 24 24
tests performed
linting performed

Description

added the istio icon and added the metadata to _data/simple-icons.json with hex value 466AB1 as provided in issue #6090 and also fixed some linting issues as well.

ericcornelissen

The SVG looks spot on (even with this low precision), nice work @swarup4741!

Before we can merge this in though, I have two requests:

Can you revert the change the package-lock.json?
If you used the SVG linked in the issue as source material, could you update the "source" to "https://github.com/istio/istio/blob/5a047251817eb2523af297607b7614120812e47a/logo/istio-bluelogo-whitebackground-unframed.svg"? Else, could you elaborate on where exactly on the website you found the SVG and why you chose it over this one?

ericcornelissen · 2021-07-17T19:19:51Z

Thank you for updating the source @swarup4741. However, it looks like the changes to package-lock.json are still there, it might be easiest to just copy the content from the package-lock.json on the develop branch and pasting it to the file on your branch (the changes are due to you using npm v7, and this project still using a lockfile generated by npm <7).

Also, I didn't catch this the first time around, but where exactly did you get the color hex value from? The SVG in the source has #466BB0, not #466AB1 🤔

swarup4741 · 2021-07-17T19:27:16Z

Thank you for updating the source @swarup4741. However, it looks like the changes to package-lock.json are still there, it might be easiest to just copy the content from the package-lock.json on the develop branch and pasting it to the file on your branch (the changes are due to you using npm v7, and this project still using a lockfile generated by npm <7).

Also, I didn't catch this the first time around, but where exactly did you get the color hex value from? The SVG in the source has #466BB0, not #466AB1 🤔

I got the hex the value by using a color picker tool... shall I update the hex value ?

ericcornelissen · 2021-07-17T19:37:15Z

I got the hex the value by using a color picker tool... shall I update the hex value ?

Using the color picker tool on the source SVG? Or on something else? From the source SVG I'm getting #466BB0 with the color picker as well. If you got the brand color from somewhere else that could be valid as well. I'm not at all familiar with the brand, but it seems blue is the brand color and I'm not seeing any specific color they prefer so running the value in the SVG seems as good as any. If you're familiar with the brand though, feel free to argue for any color you think makes sense 🙂

swarup4741 · 2021-07-17T19:38:42Z

I got the hex the value by using a color picker tool... shall I update the hex value ?

Using the color picker tool on the source SVG? Or on something else? From the source SVG I'm getting #466BB0 with the color picker as well. If you got the brand color from somewhere else that could be valid as well. I'm not at all familiar with the brand, but it seems blue is the brand color and I'm not seeing any specific color they prefer so running the value in the SVG seems as good as any. If you're familiar with the brand though, feel free to argue for any color you think makes sense 🙂

No more worries.. i updated the hex to #466BB0. Everything is ok now i suppose ...

ericcornelissen · 2021-07-17T19:47:48Z

In that case the hex value seems fine (it's always possible to change this later if someone disagrees) - the only thing left to do is revert the changes of the package-lock.json file. If you need help with that, I can do it for you before and merge it in immediately after that.

As an aside, there's no need to merge develop in whenever the option appears on your Pull Request. Generally, not much changes on the develop that will affect your work. The reason we require the branch to be up-to-date with develop at this point in time is because there are still some old Pull Requests that we know of that may require some changes in order to be merged. In any case, we will take care of merging develop into your branch when it's ready to merge for you 🙂

swarup4741 · 2021-07-17T19:51:27Z

In that case the hex value seems fine (it's always possible to change this later if someone disagrees) - the only thing left to do is revert the changes of the package-lock.json file. If you need help with that, I can do it for you before and merge it in immediately after that.

As an aside, there's no need to merge develop in whenever the option appears on your Pull Request. Generally, not much changes on the develop that will affect your work. The reason we require the branch to be up-to-date with develop at this point in time is because there are still some old Pull Requests that we know of that may require some changes in order to be merged. In any case, we will take care of merging develop into your branch when it's ready to merge for you 🙂

I have changed the package-lock.json file as per you said.. just copied the whole from develop and pasted it in my package-lock.json file in my branch and pushed it

ericcornelissen · 2021-07-17T20:00:46Z

I have changed the package-lock.json file as per you said.. just copied the whole from develop and pasted it in my package-lock.json file in my branch and pushed it

My apologies, the GitHub interface says there's 3 changed files so I assumed you didn't change anything yet 😅 Though you did revert most of the changes, you did end up changing (somehow) some of the whitespace in that file. Could you revert those changes as well? (Just to keep our commit history clean.)

swarup4741

removed the white-spaces....

ericcornelissen · 2021-07-17T20:35:14Z

removed the white-spaces....

As you can see in the GitHub UI there are still changes between package-lock.json in your branch and on develop...

If you want I can take care of this and merge this in for you 🙂 If you want to give it another try, make sure you are copying the content of package-lock.json from the most recent commit on develop, e.g. this one.

swarup4741 · 2021-07-17T20:43:04Z

removed the white-spaces....

As you can see in the GitHub UI there are still changes between package-lock.json in your branch and on develop...

If you want I can take care of this and merge this in for you 🙂 If you want to give it another try, make sure you are copying the content of package-lock.json from the most recent commit on develop, e.g. this one.

I’ll give it another try … if this time if i’m unable to fix it (somehow) then you please kindly take over and make it happen … I’ll make the changes tomorrow.. (thank you for guiding so much … I’m learning a lot)

ericcornelissen

I’ll give it another try … if this time if i’m unable to fix it (somehow) then you please kindly take over and make it happen … I’ll make the changes tomorrow.. (thank you for guiding so much … I’m learning a lot)

Almost did it, just one final newline missing in package-lock.json - fixed that one for you 🙂

Thanks for working on this one @swarup4741 🎉

* Added a new icon * Updated the hex value

# New Icons - DPD (#5831) - Dungeons & Dragons (#5837) - Grab (#6086) - Istio (#6093) - Packer (#5649) - Windi CSS (#6103) # Updated Icons - arXiv (#5884) - Douban (#6114) - Douban Read (#6114) - S7 Airlines (#6147) - Salesforce (#6147) - Samsung (#6147) - Samsung Pay (#6147) - Sass (#6147) - Scaleway (#6147) - Scania (#6147) - Scribd (#6147) - Sencha (#6147) - SEPA (#6147) - Shazam (#6147) - Shopify (#6147) - Shutterstock (#6147) - Sketch (#6147) - Slack (#6147) - SmartThings (#6147) - Snapchat (#6147) - Snapcraft (#6147) - Snowflake (#6147) - Solidity (#6147) - SonarLint (#6147) - SonarQube (#6147) - SonarSource (#6147) - Songkick (#6147) - Songoda (#6147) - Sourcegraph (#6147) - Spacemacs (#6147) - SparkPost (#6147) - Spotify (#6147) - Spreaker (#6147) - Squarespace (#6147) - Stackbit (#6147) - StackPath (#6147) - Starling Bank (#6147) - STARZ (#6147) - Statamic (#6147) - Steam (#6147) - Steinberg (#6147) - Stellar (#6147) - Streamlit (#6147) - Stylus (#6147) - Sublime Text (#6147) - Sumo Logic (#6147) - SurveyMonkey (#6147) - SUSE (#6147) - SVG (#6147) - Symfony (#6147) - Synology (#6147)

swarup4741 added 2 commits July 10, 2021 00:36

Added a new icon

0aeb628

Added a new icon

99f7953

github-actions bot added the new icon Issues or pull requests for adding a new icon label Jul 9, 2021

service-paradis changed the title ~~Added icon~~ Add Istio icon Jul 10, 2021

service-paradis linked an issue Jul 10, 2021 that may be closed by this pull request

Add Istio #6090

Closed

ericcornelissen suggested changes Jul 17, 2021

View reviewed changes

ericcornelissen added the changes requested label Jul 17, 2021

revert changes and updated icon source

46bd612

swarup4741 force-pushed the added-icon branch from 668df4e to 46bd612 Compare July 17, 2021 16:41

updated the hex value and package-lock.json

201c804

swarup4741 force-pushed the added-icon branch from b860fe9 to 201c804 Compare July 17, 2021 19:34

updated the hex value

095fb20

updated the package-lock.json

61cef79

swarup4741 force-pushed the added-icon branch from 753ac47 to 61cef79 Compare July 17, 2021 20:29

swarup4741 commented Jul 17, 2021

View reviewed changes

swarup4741 and others added 3 commits July 18, 2021 12:39

white-space removed from package-lock.json

05b2d04

Merge branch 'develop' into added-icon

ee64f41

Update package-lock.json

9550bc9

ericcornelissen approved these changes Jul 18, 2021

View reviewed changes

ericcornelissen merged commit bcc22e8 into simple-icons:develop Jul 18, 2021

github-actions bot removed the changes requested label Jul 18, 2021

dirien pushed a commit to dirien/simple-icons that referenced this pull request Jul 20, 2021

Add Istio icon (simple-icons#6093)

39287e1

* Added a new icon * Updated the hex value

github-actions bot mentioned this pull request Jul 25, 2021

Publish 6 new icons and 51 updated icons #6164

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Istio icon #6093

Add Istio icon #6093

swarup4741 commented Jul 9, 2021 •

edited

Loading

ericcornelissen left a comment

ericcornelissen commented Jul 17, 2021

swarup4741 commented Jul 17, 2021

ericcornelissen commented Jul 17, 2021

swarup4741 commented Jul 17, 2021 •

edited

Loading

ericcornelissen commented Jul 17, 2021

swarup4741 commented Jul 17, 2021

ericcornelissen commented Jul 17, 2021

swarup4741 left a comment

ericcornelissen commented Jul 17, 2021

swarup4741 commented Jul 17, 2021

ericcornelissen left a comment

Add Istio icon #6093

Add Istio icon #6093

Conversation

swarup4741 commented Jul 9, 2021 • edited Loading

Checklist

Description

ericcornelissen left a comment

Choose a reason for hiding this comment

ericcornelissen commented Jul 17, 2021

swarup4741 commented Jul 17, 2021

ericcornelissen commented Jul 17, 2021

swarup4741 commented Jul 17, 2021 • edited Loading

ericcornelissen commented Jul 17, 2021

swarup4741 commented Jul 17, 2021

ericcornelissen commented Jul 17, 2021

swarup4741 left a comment

Choose a reason for hiding this comment

ericcornelissen commented Jul 17, 2021

swarup4741 commented Jul 17, 2021

ericcornelissen left a comment

Choose a reason for hiding this comment

swarup4741 commented Jul 9, 2021 •

edited

Loading

swarup4741 commented Jul 17, 2021 •

edited

Loading