-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Carlsberg Group icon #8819
Added Carlsberg Group icon #8819
Conversation
This isn't passing all the checks, need to fiddle with the icon a bit more tonight. |
Finally got the linter to work locally...so hopefully I can get this sorted without having to push so many updates🥲 |
In their brand guideline, I didn't see a use case for the clover shape part. We may need to keep the complete trademark. Or you can reach out to them through mail or their social media for approval. |
I've sent an email to contact@carlsberg.com this afternoon asking for approval/feedback. Will keep the thread posted when I hear something back. |
@blakmagjick If you don’t get a reply soon, ping me and I’ll try reaching out internally. |
Thanks! If you could ping internally, that would likely be faster! 😸 |
Will do that! No worries and thanks! |
@wtfiscrq Any news? |
Given we've had no response, and although they include the logomark on their website, do not use it apart from the full wordmark elsewhere - I'm going to close this one down for now. If you want to re-work this to include the full wordmark @blakmagjick - be my guest and we can re-open this PR! Edit: Scrap that. They provide official brand guidelines, and explicitly only use the full wordmark. @blakmagjick - could you re-work this PR to use that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #8819 (comment)
I can definitely take a stab at it, but due to my current work schedule and moving at the end of the month, I won't be able to tackle it until after the new year....but since this has been open since July, I'm gonna guess that won't be a problem...lol |
Nah, no rush! If (like now) the branch gets conflicts with our main branch, one of us will likely resolve the conflicts - but otherwise just as/when you can get to it. If timelines look unreasonable or you don't fancy carrying on then feel free to close at any point, and someone else can start from the issue :) |
@blakmagjick, I hope you don't mind but, in the interest of moving it along, I've pushed a few updates to this PR - I'm on a bit of a rampage at the moment, trying to clear out as many issues and PRs as I can! My icon is based on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# New Icons - 7Zip (#7334) - Asahi Linux (#10245) - Babelio (#10232) - Brenntag (#10215) - Carlsberg Group (#8819) - CNET (#10228) - DaVinci Resolve (#9766) - Edge Impulse (#10201) - Esoteric Software (#10280) - Fubo (#10192) - Hyperskill (#10226) - Knex.js (#10236) - Linksys (#10231) - Nomad (#9527) - Orange (#10227) - Paramount+ (#10248) - Reactive Resume (#10225) - Solana (#10246) - Spine (#10239) - TickTick (#10224) # Updated Icons - .ENV (#10255) - .NET (#10255) - /e/ (#10269) - 1001Tracklists (#10260) - 1Password (#10256) - 42 (#10278) - 500px (#10270) - Aston Martin (#10253) - Dailymotion (#10216) - Duolingo (#10111) - Instagram (#10153) - LADA (#10155) - Minecraft (#10242) - Nintendo (#10263, #10266) - Revolut (#10238) - Zapier (#10265)
Didn't mind at all...I started a new job and this kept being pushed to the back burner for me. (Like, three weeks later I'm finally commenting...heh) Thanks for getting it over the finish line! |
Issue: closes #8813
Similarweb rank: #495,776 Globally
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description