Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Clerk #9417

Merged
merged 13 commits into from
Nov 20, 2023
Merged

Add Clerk #9417

merged 13 commits into from
Nov 20, 2023

Conversation

quantumflo
Copy link
Contributor

@quantumflo quantumflo commented Aug 26, 2023 •
edited by adamrusted

Issue: closes #9379

Similarweb rank:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Aug 26, 2023
@quantumflo quantumflo changed the title clerk New logo #9379 Add clerk New logo #9379 Aug 26, 2023
@quantumflo quantumflo changed the title Add clerk New logo #9379 Add clerk #9379 Aug 26, 2023
@quantumflo quantumflo changed the title Add clerk #9379 Add clerk #9379 Aug 26, 2023
adamrusted
adamrusted requested changes Aug 26, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @quantumflo - thanks so much for your contribution!
I can see the linter is having a few errors with the SVG, and I've got a few changes to the JSON code which I'd suggest.
If you need any help adjusting the SVG, let me know and I should be able to help you out.

_data/simple-icons.json Outdated Show resolved Hide resolved
icons/clerk.svg Outdated Show resolved Hide resolved
@adamrusted adamrusted changed the title Add clerk #9379 Add Clerk Aug 26, 2023
adamrusted
adamrusted requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround @quantumflo!
Looks like the icon has been stretched in both directions to fill the 24x24 viewport - whereas it should only be the longest side, with the aspect ratio maintained. See below for an example using the header logo against your PR.
image

Would you mind having another look at this one? 🙏

adamrusted
adamrusted requested changes Aug 29, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing minor differences between source and PR. Might be best to regenerate from source with this one @quantumflo.

@quantumflo
Copy link
Contributor Author

Still seeing minor differences between source and PR. Might be best to regenerate from source with this one @quantumflo.

Hi I would need help on this. As I am not sure on what changes needs to be done further... @adamrusted

@quantumflo
Copy link
Contributor Author

quantumflo commented Sep 2, 2023 •
edited

Still seeing minor differences between source and PR. Might be best to regenerate from source with this one @quantumflo.

Hi I would need help on this. As I am not sure on what changes needs to be done further... @adamrusted

@adamrusted What needs to be done next? I am trying to use inkspace to fix the issues and steps I followed was -

  1. scaled it vertically(longest side ) and then aligned it to center.

@adamrusted
Copy link
Member

Weird - it shouldn't be stretching that much when you edit the file.
Below is the path I've been using to compare against, feel free to use that. It should be optimised and match up.

<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Clerk</title><path d="m21.47 20.829-2.881-2.881a.572.572 0 0 0-.7-.084 6.854 6.854 0 0 1-7.081 0 .576.576 0 0 0-.7.084l-2.881 2.881a.576.576 0 0 0-.103.69.57.57 0 0 0 .166.186 12 12 0 0 0 14.113 0 .58.58 0 0 0 .239-.423.576.576 0 0 0-.172-.453Zm.002-17.668-2.88 2.88a.569.569 0 0 1-.701.084A6.857 6.857 0 0 0 8.724 8.08a6.862 6.862 0 0 0-1.222 3.692 6.86 6.86 0 0 0 .978 3.764.573.573 0 0 1-.083.699l-2.881 2.88a.567.567 0 0 1-.864-.063A11.993 11.993 0 0 1 6.771 2.7a11.99 11.99 0 0 1 14.637-.405.566.566 0 0 1 .232.418.57.57 0 0 1-.168.448Zm-7.118 12.261a3.427 3.427 0 1 0 0-6.854 3.427 3.427 0 0 0 0 6.854Z"/></svg>

@quantumflo
Copy link
Contributor Author

Weird - it shouldn't be stretching that much when you edit the file. Below is the path I've been using to compare against, feel free to use that. It should be optimised and match up.

<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Clerk</title><path d="m21.47 20.829-2.881-2.881a.572.572 0 0 0-.7-.084 6.854 6.854 0 0 1-7.081 0 .576.576 0 0 0-.7.084l-2.881 2.881a.576.576 0 0 0-.103.69.57.57 0 0 0 .166.186 12 12 0 0 0 14.113 0 .58.58 0 0 0 .239-.423.576.576 0 0 0-.172-.453Zm.002-17.668-2.88 2.88a.569.569 0 0 1-.701.084A6.857 6.857 0 0 0 8.724 8.08a6.862 6.862 0 0 0-1.222 3.692 6.86 6.86 0 0 0 .978 3.764.573.573 0 0 1-.083.699l-2.881 2.88a.567.567 0 0 1-.864-.063A11.993 11.993 0 0 1 6.771 2.7a11.99 11.99 0 0 1 14.637-.405.566.566 0 0 1 .232.418.57.57 0 0 1-.168.448Zm-7.118 12.261a3.427 3.427 0 1 0 0-6.854 3.427 3.427 0 0 0 0 6.854Z"/></svg>

Cool thanks. Updated now

@quantumflo
Copy link
Contributor Author

@adamrusted this PR can be merged?

@quantumflo
Copy link
Contributor Author

@adamrusted this PR can be merged?

Hey @adamrusted any other changes required?

@adamrusted
Copy link
Member

Apologies @quantumflo, I'm not able to review the PR given the path I contributed has been used. @simple-icons/icon-review - anyone able to give this a once over?

@adamrusted adamrusted removed their request for review November 15, 2023 12:07
PratyushJayachandran
PratyushJayachandran approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect match @adamrusted! Thanks for starting the contribution @quantumflo 🎉

@PratyushJayachandran PratyushJayachandran merged commit 166ac6d into simple-icons:develop Nov 20, 2023
4 checks passed
@github-actions github-actions bot mentioned this pull request Nov 26, 2023
Merged
mondeja added a commit that referenced this pull request Nov 26, 2023
@mondeja
Release 69 new icons and 7 updated icons and 45 removed icons (v10.0.0)
bac6a1d 
# New Icons

- Alamy (#9717)
- AlmaLinux (#9796)
- avianca (#9899)
- Basic Attention Token (#9725)
- Bevy (#7076)
- BitComet (#9563)
- Blockbench (#8060)
- BNB Chain (#9724)
- Boosty (#8897)
- Canvas (#9384)
- CBC (#9881)
- Celestron (#9898)
- Chedraui (#9568)
- Clerk (#9417)
- Crew United (#9354)
- Custom Ink (#9903)
- Depositphotos (#9714)
- Dreamstime (#9716)
- Drizzle (#9606)
- Expedia (#9912)
- Fineco (#9495)
- Google Cloud Spanner (#9472)
- Google Dataflow (#9450)
- Google Dataproc (#9451)
- Google Pub/Sub (#9466)
- Google Tasks (#9580)
- GSMArena.com (#8276)
- Headphone Zone (#9744)
- JitPack (#7701)
- Kick (#8910)
- L'&#201;quipe (#7857)
- LibreOffice Base (#9595)
- Loot Crate (#9875)
- Mahindra (#9908)
- Mailtrap (#8267)
- Medusa (#8324)
- Microsoft Store (#8802)
- NHL (#9887)
- Nordic Semiconductor (#9877)
- NSIS (#7333)
- Odoo (#6980)
- openHAB (#8548)
- OpenTofu (#9607)
- OPPO (#9556)
- Payhip (#8247)
- Phosphor Icons (#9747)
- Pi Network (#9890)
- Pine Script (#9914)
- Polestar (#9627)
- Polygon (#9723)
- PrepBytes (#9904)
- Raycast (#8987)
- Refine (#8842)
- Rive (#9878)
- RTM (#8066)
- Sam's Club (#9577)
- Session (#8246)
- Slint (#9682)
- StockX (#9889)
- Toll (#8203)
- TON (#8249)
- TradingView (#8809)
- Upptime (#9732)
- VictoriaMetrics (#9479)
- Vivint (#9882)
- W3Schools (#9326)
- WazirX (#9742)
- WezTerm (#7774)
- ZebPay (#9743)

# Updated Icons

- Appwrite (#9864)
- B&amp;R Automation (#9338)
- C# (#9528)
- Clubhouse (#9328)
- Hyundai (#9653)
- Proton Mail (#7793)
- Proton VPN (#7795)

# Removed Icons

- (ISC)&#178; (#9390)
- Ableton Live (#9306)
- Acclaim (#9301)
- AddThis (#9371)
- Anchor (#9302)
- AngelList (#9303)
- Angular Universal (#9832)
- AngularJS (#9304)
- Ask Ubuntu (#9294)
- Atom (#9305)
- Badgr (#9336)
- Bath ASU (#9341)
- BBC (#9870)
- BBC iPlayer (#9870)
- byte (#9337)
- Code Review (#9294)
- Deezer (#9856)
- Forestry (#9108)
- Hurriyetemlak (#9706)
- Hyperledger (#9655)
- Jenkins X (#9640)
- JFrog Bintray (#9641)
- LGTM (#9488)
- MediaTemple (#9534)
- Microsoft Office (#9896)
- OpenTF (#9607)
- Sendinblue (#9068)
- SonarSource (#7801)
- Sourcegraph (#9258)
- TNT (#9838)
- Twoo (#9509)
- Untangle (#9459)
- Uploaded (#9837)
- W3C (#9885)
- webhint (#9370)
- WhiteSource (#9369)
- Windi CSS (#9250)
- Winmate (#9367)
- Xilinx (#9190)
- Yahoo! (#9861)
- YOLO (#9836)
- YourTravel.TV (#9182)
- Z-Wave (#9180)
- Zend Framework (#9133)
- ZeroMQ (#9366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted requested changes

@PratyushJayachandran PratyushJayachandran PratyushJayachandran approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon request: Clerk
3 participants
@quantumflo @adamrusted @PratyushJayachandran