Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Actix icon #9461

Merged
merged 9 commits into from
Feb 8, 2024
Merged

Conversation

IamRezaMousavi
Copy link
Contributor

@IamRezaMousavi IamRezaMousavi commented Aug 30, 2023

actix

Issue: closes #8453

18.4k GitHub ⭐

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Aug 30, 2023
@adamrusted
Copy link
Member

@IamRezaMousavi is there an SVG version of the icon available on the website? All I can see are PNGs...

@adamrusted adamrusted added the vector unavailable Issues and Pull Requests where no official SVG is available. label Sep 3, 2023
@IamRezaMousavi
Copy link
Contributor Author

@IamRezaMousavi is there an SVG version of the icon available on the website? All I can see are PNGs...

No, I converted the site icon from png to svg format

@IamRezaMousavi
Copy link
Contributor Author

@adamrusted What do I need to do?

@PeterShaggyNoble
Copy link
Member

@IamRezaMousavi, could you let us know which file you based your icon on, please? So we're comparing like with like.

@PeterShaggyNoble PeterShaggyNoble added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Nov 22, 2023
@IamRezaMousavi
Copy link
Contributor Author

@IamRezaMousavi, could you let us know which file you based your icon on, please? So we're comparing like with like.

@PeterShaggyNoble please see the related issue (#8453):

Official Resources for Icon and Color
https://actix.rs/img/logo.png || color=#000000 or color=#ffffff || Taken from the header of the website

@PeterShaggyNoble PeterShaggyNoble added assessing Issues or icons that require manual input from a project maintainer before work can begin and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Dec 7, 2023
@PeterShaggyNoble
Copy link
Member

Thanks, @IamRezaMousavi. You're right, I should have checked the issue first! If I had, I would have seen that this one is currently beyond our scope on rank alone, and that it's only within our current scope on the number of stars its primary repo. However, as we are in the process of reviewing our metrics, particularly to either remove or downplay GitHub stars, I'm going to label this as assessing Issues or icons that require manual input from a project maintainer before work can begin until that issue is resolved.

If you, or @QuestionableProject, could provide us with another metric illustrating its popularity in the meantime, though, then we can proceed with reviewing this PR.

@IamRezaMousavi
Copy link
Contributor Author

You can see https://crates.io/crates/actix-web
This package has +120k downloads in past 4 days (4 Dec - 7 Dec)

@PeterShaggyNoble
Copy link
Member

That looks like a good indicator to me, @IamRezaMousavi and puts it on a par with the currently proposed minimum downloads for npm. Would any of the other @simple-icons/maintainers agree that this is popular based on that data? Or should we discuss crates.io downloads further as part of our proposed new metrics first?

@service-paradis
Copy link
Member

Looks pretty good to me!

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On to reviewing, so 😁 Nice work on this one, @IamRezaMousavi; the differences are mostly minor, which is to be expected with a manual vectorisation, but could you see if you could get the upper part of yours (in red) to line up a little better with the original?

@PeterShaggyNoble PeterShaggyNoble removed the assessing Issues or icons that require manual input from a project maintainer before work can begin label Dec 11, 2023
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating, @IamRezaMousavi, but those differences look more pronounced to me now, unfortunately. Of the 2 versions you've tried so far, I think the first is probably our better option if that's as close as you can get 👍🏻

@PeterShaggyNoble
Copy link
Member

In the interests of moving this along, I've reverted the SVG to the previous version. But I'd like one of the other @simple-icons/maintainers to have a look over it before proceeding.

@service-paradis
Copy link
Member

Well, I found something that might be interesting 😅

@adamrusted adamrusted removed their request for review February 8, 2024 18:55
@adamrusted adamrusted removed the vector unavailable Issues and Pull Requests where no official SVG is available. label Feb 8, 2024
Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 🎉

Thanks everyone that works on it!

@service-paradis service-paradis merged commit 3cd94bf into simple-icons:develop Feb 8, 2024
4 checks passed
mondeja added a commit that referenced this pull request Feb 11, 2024
# New Icons

- Actix (#9461) (@IamRezaMousavi)
- Appium (#10419) (@service-paradis)
- Better Stack (#10233) (@PeterShaggyNoble)
- Braintree (#10234) (@PeterShaggyNoble)
- Bungie (#10357) (@PeterShaggyNoble)
- Burp Suite (#10120) (@PeterShaggyNoble)
- Cloudron (#8085) (@simrahnb)
- Codefresh (#10327) (@PeterShaggyNoble)
- Excalidraw (#10241) (@PeterShaggyNoble)
- Formspree (#10385) (@service-paradis)
- Gojek (#10363) (@Mvlprem)
- Google Display & Video 360 (#10042) (@PratyushJayachandran)
- HiveMQ (#10393) (@jeoooo)
- Keenetic (#10275) (@PeterShaggyNoble)
- KNIME (#10370) (@BenHur28)
- Kununu (#10356) (@Mvlprem)
- LintCode (#10422) (@Mvlprem)
- Namu Wiki (#10328) (@PeterShaggyNoble)
- Neptune (#10316) (@PeterShaggyNoble)
- Nexus Mods (#10313) (@stefanobartoletti)
- Porkbun (#10247) (@PeterShaggyNoble)
- qbittorrent (#9596) (@21st-centuryman)
- Roll20 (#10425) (@Garbg)
- RustDesk (#10319) (@PeterShaggyNoble)
- Typst (#10399) (@Mvlprem)
- Western Union (#10383) (@Mvlprem)

# Updated Icons

- Accenture (#10424) (@Garbg)
- GitBook (#10390) (@service-paradis)
- Grammarly (#10416) (@adamrusted)
- Ruff (#10342) (@PeterShaggyNoble))

# New Icons

- Actix (#9461) (@IamRezaMousavi)
- Appium (#10419) (@service-paradis)
- Better Stack (#10233) (@PeterShaggyNoble)
- Braintree (#10234) (@PeterShaggyNoble)
- Bungie (#10357) (@PeterShaggyNoble)
- Burp Suite (#10120) (@PeterShaggyNoble)
- Cloudron (#8085) (@simrahnb)
- Codefresh (#10327) (@PeterShaggyNoble)
- Excalidraw (#10241) (@PeterShaggyNoble)
- Formspree (#10385) (@service-paradis)
- Gojek (#10363) (@Mvlprem)
- Google Display & Video 360 (#10042) (@PratyushJayachandran)
- HiveMQ (#10393) (@jeoooo)
- Keenetic (#10275) (@PeterShaggyNoble)
- KNIME (#10370) (@BenHur28)
- Kununu (#10356) (@Mvlprem)
- LintCode (#10422) (@Mvlprem)
- Namu Wiki (#10328) (@PeterShaggyNoble)
- Neptune (#10316) (@PeterShaggyNoble)
- Nexus Mods (#10313) (@stefanobartoletti)
- Porkbun (#10247) (@PeterShaggyNoble)
- qbittorrent (#9596) (@21st-centuryman)
- Roll20 (#10425) (@Garbg)
- RustDesk (#10319) (@PeterShaggyNoble)
- Typst (#10399) (@Mvlprem)
- Western Union (#10383) (@Mvlprem)

# Updated Icons

- Accenture (#10424) (@Garbg)
- GitBook (#10390) (@service-paradis)
- Grammarly (#10416) (@adamrusted)
- Ruff (#10342) (@PeterShaggyNoble)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Actix Rust framework
5 participants