Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Ritz Carlton #9872

Merged
merged 17 commits into from
Nov 26, 2023
Merged

Conversation

khamkarsuraj
Copy link
Contributor

@khamkarsuraj khamkarsuraj commented Nov 19, 2023

Issue: closes #

Similarweb rank:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Nov 19, 2023
@khamkarsuraj
Copy link
Contributor Author

Can someone help me out why these test cases are failing?

@khamkarsuraj
Copy link
Contributor Author

How to convert file format into below format?

User
<title>Riseup</title>

@adamrusted
Copy link
Member

Hey @khamkarsuraj - please review our contribution guidelines on how to submit icons to the project.
At a glance, it would appear you've left whitespace in the SVG file and the single path is wrapped in a group, which will not pass our linters. Any issues, let me know and one of us can lend a hand.

@khamkarsuraj
Copy link
Contributor Author

Hello @adamrusted
I read contribution guidelines but not good at preparing svg icon.
I have svg file ready with some other format, if you can help me to clear linters that would be helpful.

Attached unformatted svg for reference,

ritzcarlton

@adamrusted
Copy link
Member

Hey @khamkarsuraj - if you run npm install and then npx svgo icons/ritzcarlton.svg then most of the heavy lifting should be done for you on the formatting front. Also worth checking it over with npm run lint to ensure everything is formatted correctly!

@khamkarsuraj
Copy link
Contributor Author

Hello @adamrusted ,
Thank you very much for you help. I am able to clear all test cases and ready to merge. Please, have a look at my commit.

@khamkarsuraj
Copy link
Contributor Author

Hello @PratyushJayachandran ,
Please, review the files changed and accept my PR.

icons/ritzcarlton.svg Show resolved Hide resolved
icons/ritzcarlton.svg Outdated Show resolved Hide resolved
icons/ritzcarlton.svg Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @khamkarsuraj 🎉

icons/ritzcarlton.svg Show resolved Hide resolved
@PratyushJayachandran PratyushJayachandran merged commit 2c1280d into simple-icons:develop Nov 26, 2023
4 checks passed
@khamkarsuraj
Copy link
Contributor Author

Thank you, @PratyushJayachandran & @adamrusted for your valuable guidance. I learned something new. 🤝

PeterShaggyNoble added a commit to PeterShaggyNoble/simple-icons that referenced this pull request Nov 27, 2023
commit 2c1280d
Author: Suraj Khamkar <112414255+khamkarsuraj@users.noreply.github.com>
Date:   Sat Nov 25 22:12:35 2023 -0500

    Add Ritz Carlton (simple-icons#9872)

commit f607133
Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Date:   Sun Nov 26 00:26:07 2023 +0000

    version bump

commit aa232ca
Author: Adam Rusted <hello@adamrusted.me>
Date:   Sat Nov 25 23:18:32 2023 +0000

    Add Loot Crate (simple-icons#9875)

    Co-authored-by: KarlRamos <89616201+karlmathewramos@users.noreply.github.com>

commit 71fc56d
Author: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Date:   Sat Nov 25 12:13:53 2023 -0700

    Add Google Dataproc (simple-icons#9451)

commit c097dc3
Author: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Date:   Sat Nov 25 04:17:20 2023 -0700

    Add Nordic Semiconductor icon (simple-icons#9877)

commit 6e0b578
Author: Adam Rusted <hello@adamrusted.me>
Date:   Sat Nov 25 10:13:18 2023 +0000

    Add Pine Script (simple-icons#9914)

commit 57c6a79
Author: Anuja Patil <42777296+patilanuja@users.noreply.github.com>
Date:   Fri Nov 24 22:02:42 2023 -0500

    Add Custom Ink (simple-icons#9903)

commit 17cac0d
Author: Joseph <61133303+zcraber@users.noreply.github.com>
Date:   Sat Nov 25 02:48:27 2023 +0530

    Add Dreamstime (simple-icons#9716)

commit 7cab4ee
Author: Adam Rusted <hello@adamrusted.me>
Date:   Fri Nov 24 21:16:23 2023 +0000

    Add licenses and versions to third-party plugins (simple-icons#9911)

commit bdb39a6
Author: Joseph <61133303+zcraber@users.noreply.github.com>
Date:   Sat Nov 25 02:38:57 2023 +0530

    Add Alamy (simple-icons#9717)

commit f7e6d92
Author: Joseph <61133303+zcraber@users.noreply.github.com>
Date:   Sat Nov 25 02:21:56 2023 +0530

    Add BNB (simple-icons#9724)

commit 8f254cf
Author: Joseph <61133303+zcraber@users.noreply.github.com>
Date:   Sat Nov 25 00:52:43 2023 +0530

    Add Polygon (simple-icons#9723)

commit cdf5cf3
Author: Joseph <61133303+zcraber@users.noreply.github.com>
Date:   Sat Nov 25 00:44:44 2023 +0530

    Add Headphone Zone (simple-icons#9744)

commit a09c358
Author: Joseph <61133303+zcraber@users.noreply.github.com>
Date:   Sat Nov 25 00:41:21 2023 +0530

    Add ZebPay (simple-icons#9743)

commit 86a835f
Author: Joseph <61133303+zcraber@users.noreply.github.com>
Date:   Sat Nov 25 00:34:35 2023 +0530

    Add BAT (simple-icons#9725)

commit 89d7ed8
Author: Joseph <61133303+zcraber@users.noreply.github.com>
Date:   Sat Nov 25 00:30:44 2023 +0530

    Add Upptime (simple-icons#9732)

commit 1429e17
Author: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Date:   Fri Nov 24 11:51:02 2023 -0700

    Add Refine (simple-icons#8842)

    Co-authored-by: Adam Rusted <hello@adamrusted.me>
    Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>

commit 335c317
Author: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Date:   Fri Nov 24 11:43:56 2023 -0700

    Add Polestar (simple-icons#9627)

    Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>

commit 1689c05
Author: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Date:   Fri Nov 24 11:41:28 2023 -0700

    Add LibreOffice Base (simple-icons#9595)

commit a259434
Author: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Date:   Fri Nov 24 11:31:51 2023 -0700

    Add Mahindra (simple-icons#9908)

commit c272759
Author: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Date:   Fri Nov 24 11:28:36 2023 -0700

    Add BitComet (simple-icons#9563)

commit 8ba6c2f
Author: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
Date:   Fri Nov 24 18:24:07 2023 +0000

    Add Expedia (simple-icons#9912)

commit ff97c28
Author: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Date:   Fri Nov 24 07:54:45 2023 -0700

    Add Crew United (simple-icons#9354)

    Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>

commit 7e17365
Author: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Date:   Fri Nov 24 07:38:23 2023 -0700

    Add Google Tasks (simple-icons#9580)

    Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>

commit 5ae7f93
Author: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Date:   Fri Nov 24 06:23:23 2023 -0700

    Add Sam's Club (simple-icons#9577)

commit 36a68f9
Author: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Date:   Fri Nov 24 06:03:46 2023 -0700

    Add chedraui (simple-icons#9568)

    Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>

commit 815b12d
Author: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Date:   Fri Nov 24 04:54:41 2023 -0700

    Add Google Cloud Spanner (simple-icons#9472)

commit 63a6215
Author: Mirko <4560672+mu88@users.noreply.github.com>
Date:   Fri Nov 24 10:49:45 2023 +0100

    Add openHAB (simple-icons#6584) (simple-icons#8548)

    Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>

commit c45bcfc
Author: Mike Bale <64280645+ripzerotwo@users.noreply.github.com>
Date:   Fri Nov 24 03:21:48 2023 -0500

    Add Ton (simple-icons#8249)

    Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>

commit a226cde
Author: Mike Bale <64280645+ripzerotwo@users.noreply.github.com>
Date:   Fri Nov 24 03:07:07 2023 -0500

    Add Session (simple-icons#8246)

    Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>

commit c4f3d29
Author: Kane <diracsvip@gmail.com>
Date:   Fri Nov 24 14:54:04 2023 +0800

    Add AlmaLinux (simple-icons#9796)

commit 3bf2364
Author: Joseph <61133303+zcraber@users.noreply.github.com>
Date:   Fri Nov 24 07:18:02 2023 +0530

    Add WazirX (simple-icons#9742)

commit a4263a0
Author: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
Date:   Thu Nov 23 13:44:23 2023 -0700

    Add Oppo (simple-icons#9556)

commit 8b24fb5
Author: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
Date:   Thu Nov 23 20:35:46 2023 +0000

    Add PrepBytes (simple-icons#9904)

commit 40b8d35
Author: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
Date:   Thu Nov 23 20:34:37 2023 +0000

    Add Avianca (simple-icons#9899)

commit 6eea202
Author: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
Date:   Thu Nov 23 20:32:18 2023 +0000

    Add Celestron (simple-icons#9898)

commit f16c9cb
Author: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
Date:   Thu Nov 23 20:29:09 2023 +0000

    Add Pi Network (simple-icons#9890)

commit 0cdd438
Author: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
Date:   Thu Nov 23 20:27:45 2023 +0000

    Add StockX (simple-icons#9889)

commit 3c65745
Author: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
Date:   Thu Nov 23 20:24:05 2023 +0000

    Add NHL (simple-icons#9887)

commit 672d12e
Author: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
Date:   Thu Nov 23 19:40:30 2023 +0000

    Add Vivint (simple-icons#9882)

commit 921e9a8
Author: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
Date:   Thu Nov 23 19:27:08 2023 +0000

    Add CBC (simple-icons#9881)

commit 0dd7ecb
Author: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
Date:   Thu Nov 23 19:23:17 2023 +0000

    Add Rive (simple-icons#9878)

commit 3c6610d
Author: Mike Bale <64280645+ripzerotwo@users.noreply.github.com>
Date:   Thu Nov 23 13:25:30 2023 -0500

    New Icon: Payhip (simple-icons#8247)

    Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>

commit 4f49347
Author: Adam Rusted <hello@adamrusted.me>
Date:   Thu Nov 23 16:33:25 2023 +0000

    Rename OpenTF as OpenTofu (simple-icons#9607)

commit 22cfbfc
Author: Isaac Santana <zrfisaac@gmail.com>
Date:   Thu Nov 23 13:04:52 2023 -0300

    Add NSIS (simple-icons#7333)

commit 951f560
Author: Nicola Delfino <nicolgit@users.noreply.github.com>
Date:   Thu Nov 23 15:19:48 2023 +0100

    Add Fineco (simple-icons#9495)

commit 57fb708
Author: Adam Rusted <hello@adamrusted.me>
Date:   Thu Nov 23 13:36:11 2023 +0000

    Remove Microsoft Office (simple-icons#9896)

commit 893e1da
Author: Adam Rusted <hello@adamrusted.me>
Date:   Thu Nov 23 13:34:29 2023 +0000

    Remove Deezer (simple-icons#9856)

commit 0524d21
Author: Adam Rusted <hello@adamrusted.me>
Date:   Thu Nov 23 13:32:52 2023 +0000

    Removes BBC and BBC iPlayer from our collection. (simple-icons#9870)

commit c426d63
Author: Adam Rusted <hello@adamrusted.me>
Date:   Thu Nov 23 12:34:13 2023 +0000

    Add Phosphor Icons (simple-icons#9747)

commit 9c787ad
Author: Adam Rusted <hello@adamrusted.me>
Date:   Thu Nov 23 11:00:35 2023 +0000

    Remove Angular Universal (simple-icons#9832)
@adamrusted adamrusted removed their request for review December 1, 2023 19:18
mondeja added a commit that referenced this pull request Dec 3, 2023
# New Icons

- 99designs (#9987)
- 9GAG (#8329)
- Amazon Music (#9942)
- APM Terminals (#9984)
- AutoCAD (#9920)
- Autodesk Maya (#9919)
- CCleaner (#9971)
- Cloudinary (#9930)
- Codementor (#9967)
- Coggle (#9947)
- Contentstack (#9935)
- Coppel (#9960)
- Doxygen (#9735)
- EJS (#9325)
- GetX (#9901)
- Gin (#9961)
- Glovo (#9989)
- HDFC Bank (#9945)
- ICICI Bank (#6021)
- INSPIRE (#9991)
- LibreOffice Draw (#9924)
- LibreOffice Impress (#9925)
- LibreOffice Math (#9926)
- LibreOffice Writer (#9927)
- Linux Professional Institute (#9957)
- MentorCruise (#9968)
- Moqups (#9943)
- MyGet (#9975)
- netcup (#9352)
- PDQ (#9944)
- Pond5 (#9720)
- quicktype (#9966)
- Rapid (#9992)
- Raylib (#9895)
- Ritz Carlton (#9872)
- Scrapy (#9983)
- shadcn/ui (#9918)
- Soriana (#9567)
- Streamlabs (#9917)
- Tabelog (#9990)
- VEGAS (#9986)
- Visual Studio App Center (#9874)
- YouTube Kids (#9454)
- Yr (#8216)
- Ziggo (#9974)

# Updated Icons

- HelloFresh (#9962)
- Quantcast (#9959)
- Webex (#9936)
- Webflow (#9982)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants