Skip to content
This repository has been archived by the owner on May 21, 2022. It is now read-only.

Improve explanation for "Active App Notification" setting #563

Merged
merged 3 commits into from
Jun 16, 2020

Conversation

ammgws
Copy link
Contributor

@ammgws ammgws commented Dec 19, 2019

For me, it wasn't immediately 100% obvious that this setting controlled the persistent notification.

Also, the warning message was discouraging me from trying out the setting as I do not want to skip scrobbles, though I found out later that the warning is for when battery optimisations are not disabled for the app.

Hence rewrote both to make it more clear.

@ammgws ammgws marked this pull request as ready for review December 19, 2019 11:17
@ammgws ammgws changed the title Add explanation about persistent notification setting Improve explanation for "Active App Notification" setting Dec 19, 2019
Austin H added 2 commits June 16, 2020 09:33
If you turn this off (persistent notification) then ensure battery optimizations are enabled.
@a-r-db a-r-db merged commit 23d5872 into simple-last-fm-scrobbler:master Jun 16, 2020
@ammgws ammgws deleted the patch-1 branch June 16, 2020 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants