Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print branch coverage with line coverage #103

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

jeremyevans
Copy link
Contributor

Almost everyone using branch coverage is going to want to see the
branch coverage and the line coverage output.

Almost everyone using branch coverage is going to want to see the
branch coverage and the line coverage output.
@PragTob
Copy link
Collaborator

PragTob commented Sep 21, 2020

Hi @jeremyevans and thanks for your PR! Nice to see you around here 👀

And yes it is, @tycooon was/is working on something for this but also including method coverage (which they're implementing). So I'd first wanna check with them before it gives them merge conflicts :D

WhatsApp Image 2020-05-10 at 07 27 49

@gPrado
Copy link

gPrado commented Apr 5, 2021

Any news on this feature? It seems to be a very small PR, it must be simple to fix any eventual merge conflict.

@jeremyevans
Copy link
Contributor Author

It's been over 2 years. Can we please merge this or #117? As @gPrado mentioned, any merge conflict is likely to be small, so I'm not sure why that would block merging for two years. @amatsuda is it possible you could review and merge this, since it looks like you merged the most recent commits?

Copy link

@winstonwolff winstonwolff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me and I'd love to see it merged.

—Winston

@amatsuda
Copy link
Member

Merging this one, finally. Sorry for leaving this simple patch open for 3 years.

I knew that this feature was missing, but I've been thinking that I'd better not do anything besides housekeeping because I'm not the original author nor the main maintainer of this repo.
Anyway, thank you @jeremyevans for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants