Improve clarity of line and branch coverage format. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Put percentage first and then covered and total counts in brackets afterwards. Percentage is most critical at a quick glance. - Put line and brnach coverage on separate lines. Now it shows in a clean format, including covered branches, total branches and percent of covered branches. Something like this: ``` Coverage report generated for (1/10), (10/10), (2/10), (3/10), (4/10), (5/10), (6/10), (7/10), (8/10), (9/10) to /Users/me/Development/cntral/coverage. Line Coverage: 58.44% (7554 / 12927) Branch Coverage: 50.43% (1868 / 3704) ``` When branch coverage is not enabled it simply omits that line, so it appears like this: ``` Coverage report generated for (1/10), (10/10), (2/10), (3/10), (4/10), (5/10), (6/10), (7/10), (8/10), (9/10) to /Users/me/Development/cntral/coverage. Line Coverage: 58.44% (7554 / 12927) ```
joshuapinter
force-pushed
the
put_coverage_percentage_first
branch
from
8b79c2f
to
e2b0025
Compare
|
I like this new format indeed. So let me merge this. |
|
@amatsuda 👏 🙏 Thank you. I totally forgot about this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put percentage first and then covered and total counts in brackets afterwards. Percentage is most critical at a quick glance.
Put line and brnach coverage on separate lines.
Before
Coverage report generated for (1/10), (10/10), (2/10), (3/10), (4/10), (5/10), (6/10), (7/10), (8/10), (9/10) to /Users/me/Development/cntral/coverage. 8534 / 16083 LOC (53.06%) covered. 2225 / 4749 branches (46.85%) covered.After
Now it shows in a clean format, including covered branches, total branches and percent of covered branches. Something like this:
When branch coverage is not enabled it simply omits that line, so it appears like this: