Inline images into application.css during asset compilation #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This proc changes `url()` calls in *.css
e.g.) background-image: url("DataTables-1.10.20/images/sort_both.png");
into base64 encoded inline image via `rake assets:compile`.
Note that all images referenced in CSS will be loaded this way, whether
or not the user enables SIMPLECOV_INLINE_ASSETS option.
This idea and code is taken from
simplecov-ruby#113 by @AMHOL
Co-authored-by: AMHOL <andyholland1991@aol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a Sprockets processor that in-lines images into the compiled CSS file.
The inline asset mode implemented at #107 generates a single HTML file that inlines all the assets, but indeed it still misses one thing, i.e. images referenced from inside .css files.
That problem has already been addressed by @AMHOL via #113, so I extracted the Sprockets processor proc from that PR, leaving the credit as a co-author on @AMHOL.
Since this hack is based on SassProcessor mechanism, we had to switch the whole CSS processing and compressing from yui-compressor to sass. I know that Ruby implementation of sass gem is no longer actively developed, but it seems to work here so far.