Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for earlephilhower/arduino-pico #234

Closed
wants to merge 1 commit into from

Conversation

suryavip
Copy link
Contributor

@suryavip suryavip commented Jan 1, 2023

Some PWM functions (like pwm_gpio_to_slice_num) are not found in the scope when using arduino-pico board library from @earlephilhower. Adding #include "hardware/pwm.h" solve the problems for me.

Some PWM functions (like `pwm_gpio_to_slice_num`) are not found in the scope when using arduino-pico board library from earlephilhower. Adding `#include "hardware/pwm.h"` solve the problems for me.
@runger1101001
Copy link
Member

I will look into this. I want to run some other tests on pico hardware anyway.

Thank you very much for reporting it!

PS: we only accept pull requests into the dev branch of SimpleFOC. I will change it.

@runger1101001 runger1101001 changed the base branch from master to dev January 1, 2023 18:11
@runger1101001
Copy link
Member

Nice, this looks like it is working!

I will add it to the code. I can't merge this pull request against the dev branch, it has conflicts. I think the file that was patched has been moved on the dev branch...

But as its only one line I will just add it in.

@runger1101001
Copy link
Member

It's merged into the dev branch, as part of PR #236

It will be part of the next release, thank you so much!

@mawildoer
Copy link

I'm having some trouble with the 6PWM output on the earlephilhower/arduino-pico platform, but it seems to be working fine with the offical raspberrypi platform.

Specifically, I'm not seeing any output on earlephilhower/arduino-pico at all. I'm wondering if it's using the generic_mcu function or something? Perhaps TARGET_RP2040 isn't set properly? I'm not sure where that's supposed to be provided (eg. from the compiler?).

@runger1101001
Copy link
Member

It’s possible, I’ll take another look.

are you using platformio or ArduinoIDE?

@runger1101001 runger1101001 reopened this Jul 8, 2023
@runger1101001
Copy link
Member

Closing PR again, thought it was an issue

@mawildoer
Copy link

Using platformio.

Got a motor spinning just fine tiger the raspberrypi platform, but still no output at all from earlephilhower.

Sorry, perhaps I misunderstood the comment, but would you prefer I open another issue? I know this is a new feature so wanted to check existing threads first. Let me know if there’s anything I can do to help debug!

@runger1101001
Copy link
Member

Yes, this one is a pull request that has already been merged… if you like you could open a new issue.

do you have the lib_archive=false option in your platformio.ini file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants