-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
408 feature support for arduino esp32 v301 current sensing #414
Merged
askuric
merged 27 commits into
dev
from
408-feature-support-for-arduino-esp32-v301-current_sensing
Jun 23, 2024
Merged
408 feature support for arduino esp32 v301 current sensing #414
askuric
merged 27 commits into
dev
from
408-feature-support-for-arduino-esp32-v301-current_sensing
Jun 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the new esp32 api
…ense with the new esp32 api" This reverts commit a7ed4ba.
…eturning error if no low-side
This was
linked to
issues
Jun 22, 2024
This was
linked to
issues
Jun 22, 2024
We're going for the merge! 🎉 :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok so this is the final pull request that unifies all the changes necessary for the API transition from v2.x to v3.x arduino-esp32.
Main changes:
Other new features:
_driverSyncLowSide
return-1
if it fails, so there are a few slight changes other mcu types, not just esp32_configureLowSide
and_readADCVolatgeLowSide
return-1
(and display a debugging error) by default instead of calling their inline equivalents. This is a safety measure to avoid using suing low-side current sensing if it's not available.The code was tested on esp32 and esp32s3 variants, so it is relatively mature.
It needs much more testing, but I think that it should be fine for the dev branch.