Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include keywords from UIInfo in DiscoPower search. #12

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

thijskh
Copy link
Member

@thijskh thijskh commented Jan 11, 2022

If an entity has any UIInfo.Keywords set for the current language, or for English, it will be added to this entity's search text which is used when using the typeahead search in the search box. Any match on a keyword will then count the same as a match on words in the entity name.

If an entity has any UIInfo.Keywords set for the current language,
or for English, it will be added to this entity's search text.
Any match on a keyword will then count the same as a match on words
in the entity name.
@thijskh thijskh requested a review from ghalse January 11, 2022 20:56
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #12 (33a0fc9) into master (3690f53) will increase coverage by 0.17%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #12      +/-   ##
============================================
+ Coverage     31.25%   31.42%   +0.17%     
  Complexity       82       82              
============================================
  Files             2        2              
  Lines           208      210       +2     
============================================
+ Hits             65       66       +1     
- Misses          143      144       +1     

@thijskh thijskh merged commit bd2cee9 into master Jan 28, 2022
@thijskh thijskh deleted the feature/include-keywords-in-search branch January 28, 2022 14:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants