Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: list param name #10

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Feat: list param name #10

merged 2 commits into from
Jan 10, 2025

Conversation

Drejzer
Copy link
Member

@Drejzer Drejzer commented Jan 10, 2025

Overlooked parameter name changes in listing methods

Additions:

  • listStores(contextId:pagingQuery:)
  • listFiles(storeId:pagingQuery:)
  • listThreads(contextId:pagingQuery:)
  • listMessages(threadId:pagingQuery:)

Modifications:

Deprecations:

  • listStores(contextId:query:)
  • listFiles(storeId:query:)
  • listThreads(contextId:query:)
  • listMessages(threadId:query:)

Parameter name changes:

  • NativeStoreApiWrapper::listStores()
  • NativeStoreApiWrapper::listFiles()
  • NativeThreadApiWrapper::listThreads()
  • NativeThreadApiWrapper::listMessages()

@Drejzer Drejzer self-assigned this Jan 10, 2025
@Drejzer Drejzer merged commit dc5d459 into 2.1.0-staging Jan 10, 2025
@Drejzer Drejzer deleted the feat/list-param-name branch January 10, 2025 16:04
@Drejzer Drejzer changed the title Feat! : list param name Feat: list param name Jan 10, 2025
Drejzer added a commit that referenced this pull request Feb 3, 2025
* Chore: PrivMX Endpoint library v2.1.4

* Feat(Core): New conenction methods in Connection (#5)

* Feat: Support for policies (#7)

* Docs: Documentation in the modified methods

* Docs: Fixed documentation of makeOptional() methods

* Fix: Removed wrongfully added platforms

* Feat: Overlooked parameter name changes in listing methods (#10)

* Feat Parameter names in listStores and listFiles

* Feat: Parameter names in listThreads and listMessages

* Fix: Deprecated listing methods in StoreApi

* Feat: added getDescription to PrivMXEndpointError (#11)

* Feat: added missing updateFileMeta method to StoreApi (#12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant