-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent errors in Folder to S4TK Project by sanitizing the filenames #2
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, I'll definitely include file name sanitizing, that should have been in there from the start. I just want a few structural changes to make it more consistent with how the rest of the codebase is written.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'll merge soon and do some testing, not 100% sure when I'll be able to get the next release out though.
also name the SimData files according to the convention https://vscode.sims4toolkit.com/#/features/resource-keys