New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent errors in Folder to S4TK Project by sanitizing the filenames #2

Open

mycroftjr wants to merge 7 commits into sims4toolkit:main from mycroftjr:main

mycroftjr commented Aug 30, 2023 •

edited

Loading

also name the SimData files according to the convention https://vscode.sims4toolkit.com/#/features/resource-keys

mycroftjr added 5 commits

August 29, 2023 20:18


          sanitize filenames

e96719e


          correct usage

76df8dd


          improve folder to S4TK SimData naming

c1bcebb


          also set the SimData instance names

5b596eb


          use the same sanitization for Clone Tuning

606bd53

frankkulak reviewed

View reviewed changes

src/core/tuning/commands.ts Outdated Show resolved Hide resolved

frankkulak reviewed

View reviewed changes

src/core/tuning/commands.ts Outdated Show resolved Hide resolved

frankkulak reviewed

View reviewed changes

src/core/workspace/folder-to-project.ts Outdated Show resolved Hide resolved

frankkulak reviewed

View reviewed changes

src/core/workspace/folder-to-project.ts Outdated Show resolved Hide resolved

frankkulak reviewed

View reviewed changes

src/core/workspace/folder-to-project.ts Outdated Show resolved Hide resolved

frankkulak reviewed

View reviewed changes

src/core/workspace/folder-to-project.ts Outdated Show resolved Hide resolved

frankkulak requested changes

View reviewed changes

Contributor

frankkulak left a comment

Thanks for the contribution, I'll definitely include file name sanitizing, that should have been in there from the start. I just want a few structural changes to make it more consistent with how the rest of the codebase is written.


          requested changes

48103e7

mycroftjr requested a review from frankkulak

September 15, 2023 04:38

frankkulak reviewed

View reviewed changes

schemas/s4tk-config.schema.json Show resolved Hide resolved

frankkulak approved these changes

View reviewed changes

Contributor

frankkulak left a comment

Looks good! I'll merge soon and do some testing, not 100% sure when I'll be able to get the next release out though.


          Merge branch 'main' into main

e9ed469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet