[Warlock] [Demonology] Updates conversion rates of Felguard and G.Felguard #9747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mlklock
commented
Nov 18, 2024
There was a problem hiding this comment.
Adjusted the SP to SP following the values of my felguard https://i.imgur.com/smt8RGM.png with my warlock at 17.647 intellect.
|
To further validate the values used here https://www.warcraftlogs.com/reports/nWmwA2pc139PyJNH#fight=last&type=resources&source=3&spell=1001 Felguard AP(16743) Character Intellect: 17647 SP TO AP conversion = 0.9487731625772086, Value in this PR 0.9487 |
Mlklock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the Conversion rates of AP and SP for Felguard and G.Felguard, apparently, any buff/change to Conversion rates of Felguard ingame will reflect to G.Felguard.
On a side note, i opted to not update the Conversion Rates of Dreadstalkers at this PRequest and will do it on a different PR in the future.
https://imgur.com/EzfMdEp
As you can see, at a 16743 Attack Power with 17647 Intellect would indicate the new values for AP/SP conversion rates.