-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting stuck at 75% - server assets to delete #343
Comments
@simulot it does seem like this line never returns: immich-go/cmd/upload/upload.go Line 854 in abd793e
|
I'm not seeing it implemented anywhere |
Server's assets are deleted only when the uploaded asset is a better. (same name, same date of capture) It's implemented, otherwise the program would not compile. Lines 190 to 200 in abd793e
125K files... A big take! |
Have you noticed errors during the upload? This is not good... What the log file says about the errors? |
Yeah, I think the operation times out - how could we fix that? |
https://github.com/simulot/immich-go?tab=readme-ov-file#shared-options-with-all-commands |
So, I tried that, but the moment all the active jobs are processed the process terminates.
Log output:
|
I'm re-running the script with a packet sniffer and some more logging. Will report back results |
I added some more logging:
It looks like the line got cut off! Maybe the payload is too big? |
I'm trying deleting in batches of 50 UUIDs - I wonder if this failure is on the client or server side. |
@simulot any ideas? |
No. How beefy is your server? |
Umbrel Home - 2.9 GhZ Quad Core 16GB memory |
Definitively not a PI4 |
I'm working on create a trace file |
Oops, I haven't seen your trace on my mobile. On delete assets... Could you get the request body? |
Request:
Payload:
This seriously looks like something's wrong with Immich not the client. |
I think with |
I'm wondering if one of the IDs isn't valid anymore when trying to delete as stated in the error message. |
yes, I think you're right. Later tonight, I'll try deleting in batches of 10, and continue on failure. It shouldn't get stuck only because of a 400 |
Fixed! |
Can confirm that fix is effective! No more getting stuck! Thank you. However, wdyt about this output:
The numbers don't add up |
😫 |
|
upload... |
in the coming release, server's assets to be deleted are immediately deleted instead of been accumulated and deleted at the end. |
the reason of x% stuck could be the #376 |
Version: immich-go 0.18.1, commit abd793e, built at 2024-06-30T19:14:17Z
As mentioned, my upload is getting stuck at 75% - this is the second time I try.
The text was updated successfully, but these errors were encountered: