Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix recent bugs #15

Merged
merged 6 commits into from
Feb 16, 2023
Merged

fix recent bugs #15

merged 6 commits into from
Feb 16, 2023

Conversation

tsalehm
Copy link
Contributor

@tsalehm tsalehm commented Feb 6, 2023

this PR fixes recent bugs caused by merging last PRs

@sinadarvi please don't merge PR's that are not checkd by yourself or someone else

@tsalehm tsalehm mentioned this pull request Feb 6, 2023
Closed
sinadarvi
sinadarvi approved these changes Feb 16, 2023
View reviewed changes
Copy link
Owner

@sinadarvi sinadarvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not test and confirm or deny it because I have no Linux system around. but I hope this would fix the issue as you told me. if this doesn't work, I think it would be better to switch to old commits 😅 but I hope this PR works. thanks.

@sinadarvi sinadarvi merged commit 4a91f4f into sinadarvi:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinadarvi sinadarvi sinadarvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsalehm @sinadarvi