Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed Shift+G to correctly type ۀ (u+06C0) instead of ة (u+0629) #9

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

cs127
Copy link
Contributor

@cs127 cs127 commented Jul 20, 2022

Shift+G should be ۀ (u+06C0), not ة (u+0629).
there is already a key for 0629: Shift+Z.

@cs127 cs127 reopened this Mar 8, 2023
@sinadarvi
Copy link
Owner

a lot has changed since this pr has been here. please check if everything matches with the newer version.

@cs127
Copy link
Contributor Author

cs127 commented Mar 8, 2023

a lot has changed since this pr has been here. please check if everything matches with the newer version.

Read my latest comment on #16.

Copy link
Owner

@sinadarvi sinadarvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@sinadarvi sinadarvi merged commit 5a9ed2c into sinadarvi:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants