Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

tab_with does not fall back to indent_size #91

Closed
florianb opened this issue May 20, 2016 · 1 comment · Fixed by #106
Closed

tab_with does not fall back to indent_size #91

florianb opened this issue May 20, 2016 · 1 comment · Fixed by #106
Assignees

Comments

@florianb
Copy link
Collaborator

Derived from federomero/pretty-json#36

As EditorConfig-Properties states:

"defaults indent_size when indent_size is a number"

Currently tab_with does not fall back to indent_size.

@florianb florianb added the bug label May 20, 2016
@florianb florianb self-assigned this May 20, 2016
@florianb florianb added this to the Fievel Mousekewitz milestone Oct 17, 2016
@florianb
Copy link
Collaborator Author

This will be solved with acceptance of the pending PR #104.

florianb pushed a commit that referenced this issue Oct 20, 2016
This is the final reorder of the PRs around the next minor release fulfilling containing the following changes:

* Clicking in the statusbar-icon displays a notification, showing the currently applied config and helpful tips if something seems misconfigured (fixes #89)
* Added clickable statusbar-icon to reflect the state of atom-editorconfig for the currently displayed TextBuffer
* Editing `.editorconfig`-files from within Atom now reapplies the settings to all open editors (fixes #85)
* The `trim_trailing_whitespace`-property is now implemented (fixes #3)
* The `insert_final_newline`-property is now implemented (fixes #4)
* The `generate`-command now uses `config.get()` to fetch the defaults for `trim_trailing_whitespace` and `insert_final_newline` (fixes #94)
* The `tab_width`-property now falls back to `indent_size` if missing (fixes #91)

This PR takes the PRs #104 & #102 over.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant