Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add electron-localshortcut #127

Closed
wants to merge 1 commit into from
Closed

Add electron-localshortcut #127

wants to merge 1 commit into from

Conversation

parro-it
Copy link
Contributor

@parro-it parro-it commented Nov 3, 2015

electron-localshortcut is a module to register/unregister a keyboard shortcut locally to a BrowserWindow instance, without using a Menu.

@sindresorhus
Copy link
Owner

Any way we can make the description a tad shorter?

Maybe:

Add keyboard shortcuts locally to a window

@sindresorhus
Copy link
Owner

Can you link to electron/electron#1334 at the top of your readme?

@sindresorhus
Copy link
Owner

Nice! Might be worth using this in electron-debug?

@parro-it
Copy link
Contributor Author

parro-it commented Nov 4, 2015

Thank you!

  • Description shortened
  • Issue linked, good suggestion
  • Yes, I can add it to electron-debug with a PR if you want

@sindresorhus sindresorhus changed the title add electron-localshortcut to tools list Add electron-localshortcut Nov 4, 2015
@sindresorhus
Copy link
Owner

Yes, I can add it to electron-debug with a PR if you want

👍

sindresorhus pushed a commit that referenced this pull request Nov 4, 2015
@parro-it
Copy link
Contributor Author

parro-it commented Nov 4, 2015

I'm thinking of add these feature before:

// This is global, if any window in the app is focused it works
LocalShortcut.register(accelerator, callback);

@maxkorp suggest it in the electron issue.
It could be ideal for electron-debug

@sindresorhus
Copy link
Owner

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants