-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SAP Commerce #2925
base: main
Are you sure you want to change the base?
Add SAP Commerce #2925
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
|
|
What is Hybris? |
Hybris is an e-commerce platform using Java, based on Spring MVC framework. |
Hello @Ritalin35 Thanks for your review. You wrote "svg' in my PR. Can you please explain me what svg standa for ? |
H @Pinkolinka11 you wrote "record" as a review. Can you please explain in detail ? |
Getting latest code from the main repository
c05ec08
to
bbe1e6f
Compare
The list should use the current product name "SAP Commerce". |
Hi @sindresorhus , I renamed as SAP Commerce in both awsome list and PR. Thanks for the review. |
Drop the "It's a" part. Applies in multiple places. |
Many entries are missing a description. |
The "Blogs" entries should have proper titles.
|
I updated title case in blogs section and removed starting with "it's" in descriptions |
Hi, I Improved the descriptions. |
Hi, Do you have any comments about it ? |
f0658c5
to
993cee4
Compare
Descriptions should not be title-cased. Items in the "Videos" section needs proper descriptions. |
Hello @sindresorhus, |
Forgot to mention one more thing, will be good to add official link to https://www.sap.com/products/crm/commerce-cloud.html in the "About" of the repository: |
Hi @DanailMinchev, I added the url link in the about. Thank you. |
https://github.com/eminyagiz42/awesome-sap-commerce
I've created a dedicated awesome list about SAP Commerce. As that is a part of Java community and commonly used Java technologies such as Spring MVC, Apache Ant, Solr and Groovy platform. I thought it could be worth being linked from here.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Add Name of List
. It should not contain the wordAwesome
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Awesome X
and a logo withAwesome X
. You can put the header image in a#
(Markdown header) or<h1>
.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. The casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.
##Contributions
#2878 (comment)
#2810 (comment)