-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: height and fullscreen option #75
Conversation
// @LitoMore |
@sindresorhus Should we really wait for @LitoMore ? The features are there and working as expected ;) |
I will take a look. |
Please add some tests for the BTW, as we discussed before at #29 (comment), the |
Readme needs to be updated. |
@LitoMore I'm wondering if having the possibility to use a function as argument isn't too much complexity for little benefits |
See #29 (comment). |
// @LitoMore |
Should this be considered done ? :) @sindresorhus |
Looks good :) |
In answer to #29 , here I have added an height constraint option and a fullscreen option.
Example with height option:
Sorry for the wait, I have found a job and couldn't find many time to focus on this issue.
Fixes #29