Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: height and fullscreen option #75

Merged
merged 11 commits into from
Jun 13, 2022

Conversation

Caesarovich
Copy link
Collaborator

@Caesarovich Caesarovich commented May 13, 2022

In answer to #29 , here I have added an height constraint option and a fullscreen option.

Example with height option:

import boxen from 'boxen';

console.log(boxen('foo bar', {height: 5}));
// ┌───────┐
// │foo bar│
// │       │
// │       │
// └───────┘

Sorry for the wait, I have found a job and couldn't find many time to focus on this issue.


Fixes #29

@sindresorhus
Copy link
Owner

// @LitoMore

@Caesarovich
Copy link
Collaborator Author

@sindresorhus Should we really wait for @LitoMore ? The features are there and working as expected ;)

@LitoMore
Copy link
Contributor

@sindresorhus Should we really wait for @LitoMore ? The features are there and working as expected ;)

I will take a look.

@LitoMore
Copy link
Contributor

Please add some tests for the fullscreen option.

BTW, as we discussed before at #29 (comment), the fullscreen option should be able to accept a function for modifications.

index.d.ts Show resolved Hide resolved
@LitoMore
Copy link
Contributor

Readme needs to be updated.

index.d.ts Outdated Show resolved Hide resolved
@Caesarovich
Copy link
Collaborator Author

@LitoMore I'm wondering if having the possibility to use a function as argument isn't too much complexity for little benefits

@LitoMore
Copy link
Contributor

I'm wondering if having the possibility to use a function as argument isn't too much complexity for little benefits

See #29 (comment).

@Caesarovich
Copy link
Collaborator Author

// @LitoMore

index.d.ts Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
tests/fullscreen-option.js Outdated Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
@Caesarovich
Copy link
Collaborator Author

Should this be considered done ? :) @sindresorhus

@sindresorhus sindresorhus merged commit d6b4b32 into sindresorhus:main Jun 13, 2022
@sindresorhus
Copy link
Owner

Looks good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fullscreen option
3 participants