Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completes implementation of borderStyle "none" #89

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Completes implementation of borderStyle "none" #89

merged 3 commits into from
Jul 4, 2023

Conversation

roydukkey
Copy link
Contributor

@roydukkey roydukkey commented May 10, 2023 •
edited
Loading

#88 doesn't completely implement the feature requested in #84

  • Fix width when borderStyle is "none"
  • Remove prepended blank line when:
    1. borderStyle is "none",
    2. title is undefined,
    3. and both padding and margin are 0
  • Remove appended blank line when:
    1. borderStyle is "none",
    2. height is not greater than the intrinsic maximum height of the content,
    3. and both padding and margin are 0

@roydukkey roydukkey marked this pull request as ready for review May 10, 2023 03:55
@sindresorhus sindresorhus merged commit ef5c987 into sindresorhus:main Jul 4, 2023
@victorperin victorperin mentioned this pull request Jun 15, 2024
Open
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caesarovich Caesarovich Caesarovich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roydukkey @Caesarovich @sindresorhus