-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for JSON schema #58
Conversation
You need to consider how the |
This PR is a bit thin considering the expected work for the bounty. |
The readme documentation should have a full realistic example of how it should be used. Meaning, various kinds of types and validations options. |
Also go through all the options in https://github.com/epoberezkin/ajv#validation-and-reporting-options and carefully consider which one to use or not. |
We should at least have these options: https://github.com/wulkano/kap/blob/01a557f6616108423f9e46718d48596a22698480/main/plugin.js#L48-L53 |
Can you fix the merge conflict? |
I go through all the options for ajv:
|
Co-Authored-By: yaodingyd <yaodingyd@gmail.com>
I was wrong about the overwrite order before: actually we apply Conf's defaults first, thus schema's default would not be used because value has already be set. I have updated doc accordingly. |
Can you add the option to https://github.com/sindresorhus/conf/blob/master/index.d.ts and https://github.com/sindresorhus/conf/blob/master/index.test-d.ts ? And fix the merge conflict. |
Looks good now :) |
Fix sindresorhus/electron-store#16
Use epoberezkin/ajv for JSON schema validation