ES2015ify

[schnittstabil]

ES2015ify

• Remove readable-stream (only needed for v0.10)
• Remove mkdirp 'EEXIST' checks
• Remove rewire in favor of clear-require and require-uncached

Closes: #13

Notes:

• Looks like mkdirp doesn't throw 'EEXIST' errors (anymore?)
• rewire doesn't work with ES2015 const

Further improvements, but BC:

• Paths in error messages (Compare system errors: ENOENT: no such file or directory, stat 'x'):

- new CpFileError(`cannot read from \`${path}\`: ${err.message}`)
+ new CpFileError(`cannot read from '${path}': ${err.message}`)
// and to be consistent:
- new CpFileError('`src` and `dest` required')
+ new CpFileError(`'src' and 'dest' required`)

[sindresorhus]

Looks very good!

[sindresorhus]

The correct way for ES2015 classes is to set this.name in the constructor instead.

[sindresorhus]

Can be simplified now:

const EventEmitter = require('events');

[sindresorhus]

I would keep the private state in a WeakMap and make the written a prototype getter/setter. See: http://www.2ality.com/2016/01/private-data-classes.html

[schnittstabil]

Yeah, @rauschma rocks 🤘

[rauschma]

🙏

[sindresorhus]

Paths in error messages (Compare system errors: ENOENT: no such file or directory, stat 'x'):

I don't really care much what Node.js core does. It's not a great example of good error messages. I prefer the backtick as that's what we also use in Markdown to highlight some kind of value.

[schnittstabil]

@sindresorhus updated; Thanks for the fast review 🙂

[sindresorhus]

Yay! Very nice work @schnittstabil :)