Skip to content

Commit

Permalink
Mention the DMG filename in the completed message
Browse files Browse the repository at this point in the history
Fixes #55
  • Loading branch information
sindresorhus committed Jun 11, 2020
1 parent 620403c commit cde05c0
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ async function init() {
}

const dmgTitle = cli.flags.dmgTitle || appName;
const dmgPath = path.join(destinationPath, `${appName} ${appInfo.CFBundleShortVersionString}.dmg`);
const dmgFilename = `${appName} ${appInfo.CFBundleShortVersionString}.dmg`;
const dmgPath = path.join(destinationPath, dmgFilename);

if (dmgTitle > 27) {
ora.fail('The disk image title cannot exceed 27 characters. This is a limitation in a dependency: https://github.com/LinusU/node-alias/issues/7');
Expand Down Expand Up @@ -189,7 +190,7 @@ async function init() {
}

ora.info(`Code signing identity: ${match[1]}`).start();
ora.succeed('DMG created');
ora.succeed(`Created “${dmgFilename}”`);
} catch (error) {
ora.fail(`Code signing failed. The DMG is fine, just not code signed.\n${Object.prototype.hasOwnProperty.call(error, 'stderr') ? error.stderr.trim() : error}`);
process.exit(2);
Expand Down

0 comments on commit cde05c0

Please sign in to comment.