Allow non-glob patterns with backslash on Windows #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this is a good middle ground. Can you update the readme: https://github.com/sindresorhus/del#api |
sindresorhus
changed the title
|
I removed the note regarding backward slashes (basically reverted the change 9e7550b). Is this what you wanted? |
|
I don't think we should remove the notes, as glob patterns do still need to only have forward slash. Just mention that normal file paths can have forward slashes. |
This reverts commit 60e9d54.
How does that sound? |
|
Perfect. Can you fix the merge conflict? |
|
Fixed! |
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the breaking change in
5.0.0not allowing windows to pass direct paths to del making del easier to use on windows.Fixes #105