Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort removed files #102

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Sort removed files #102

merged 1 commit into from
Jul 16, 2019

Conversation

chrisblossom
Copy link
Contributor

#99 (comment) After thinking about this comment I think this PR should be updated to use .sort((a, b) => a.localeCompare(b)) instead of .reverse() to consistently return the same order every time.

@sindresorhus sindresorhus merged commit ca05c65 into sindresorhus:master Jul 16, 2019
@chrisblossom chrisblossom deleted the consistent-return-order branch July 16, 2019 17:50
This was referenced Oct 26, 2019
Open
Open
@Omrisnyk Omrisnyk mentioned this pull request Dec 1, 2023
Open
@Omrisnyk Omrisnyk mentioned this pull request May 26, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Oct 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisblossom @sindresorhus