Add TypeScript definition #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Mar 3, 2019
index.d.ts
Outdated
| * | ||
| * @example | ||
| * | ||
| * const del = require('del'); |
There was a problem hiding this comment.
Use import syntax. This is supposed to be a TS usage example.
Suggested change
| * const del = require('del'); | |
| * import del from 'del'; |
sindresorhus
reviewed
Mar 3, 2019
| @@ -0,0 +1,22 @@ | |||
| import {expectType} from 'tsd-check'; | |||
| import del, {sync as delSync} from '.'; | |||
There was a problem hiding this comment.
Am I the only one that finds this ugly? Should the sync just be a property of the default export instead of a named export? Or should we name the named export delSync so it doesn't have to be renamed to that?
There was a problem hiding this comment.
I'm not a fan of default imports. They're always kinda ugly, everyone names the thing differently and the tooling has hard times determining what you actually want to import. It's much easier with named exports.
sindresorhus
pushed a commit
that referenced
this pull request
Mar 3, 2019
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.