Return default value if path is invalid #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Merged
Richienb
changed the title
sindresorhus
reviewed
Sep 8, 2021
Test, not assertion. |
Richienb
commented
Sep 8, 2021
test.js
Outdated
| @@ -215,5 +215,5 @@ test('prevent setting/getting `__proto__`', t => { | |||
| }); | |||
|
|
|||
| test('return default value if path is invalid', t => { | |||
| t.is(dotProp.get({}, '__proto__', '🦄'), '🦄'); | |||
| t.is(dotProp.get({}, 'nonexistent', '🦄'), '🦄'); | |||
There was a problem hiding this comment.
The path is only "invalid" if a disallowed property is passed. Testing for a legal property is already tested for.
There was a problem hiding this comment.
Is there any other non-legal value we could use that is not __proto__?
There was a problem hiding this comment.
Lines 5 to 7 in 09adad9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last untested part of the code (#70)