Fix the internal IPC to only subscribe to events once #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On each construction of an ElectronStore instance, the initDataListener method is called. This causes duplicate ipcMain handlers for the 'electron-store-get-data' channel. Found that this causes an Electron EventEmitter warning of 'MaxListenersExceededWarning'. By setting an initialiser flag, events are handled as needed and does not cause this warning. Additionally if someone were to properly exceed this (in my case I was at 11), by dynamically creating larger amounts of stores (which could be possible in larger scale applications, although not recommended), this could have dangerous and odd side-effects.
sindresorhus
requested changes
Apr 6, 2021
Completed requested changes.
|
Re #180 (comment), you did not correctly copy the name I wrote. |
sindresorhus
reviewed
Apr 7, 2021
Making sure to AmericaniZe myself. Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Original change was not fully American, needed to add some more Bald Eagles.
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On each construction of an ElectronStore instance, the initDataListener method is called. This causes duplicate ipcMain handlers for the 'electron-store-get-data' channel. Found that this causes an Electron EventEmitter warning of 'MaxListenersExceededWarning'. By setting an initialiser flag, events are handled as needed and does not cause this warning. Additionally if someone were to properly exceed this (in my case I was at 11), by dynamically creating larger amounts of stores (which could be possible in larger scale applications, although not recommended), this could have dangerous and odd side-effects.