Fix directive check in no-empty-file for TypeScript parser

sindresorhus · Jul 23, 2023 · 4952099 · 4952099
1 parent 1b6757e
commit 4952099
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -67,7 +67,7 @@
 		"@babel/core": "^7.22.8",
 		"@babel/eslint-parser": "^7.22.7",
 		"@lubien/fixture-beta-package": "^1.0.0-beta.1",
-		"@typescript-eslint/parser": "^5.61.0",
+		"@typescript-eslint/parser": "^6.1.0",
 		"ava": "^3.15.0",
 		"c8": "^8.0.0",
 		"chalk": "^5.3.0",

diff --git a/rules/no-empty-file.js b/rules/no-empty-file.js
@@ -6,7 +6,7 @@ const messages = {
 	[MESSAGE_ID]: 'Empty files are not allowed.',
 };
 
-const isDirective = node => node.type === 'ExpressionStatement' && 'directive' in node;
+const isDirective = node => node.type === 'ExpressionStatement' && node.directive !== undefined;
 const isEmpty = node => isEmptyNode(node, isDirective);
 
 const isTripleSlashDirective = node =>

diff --git a/test/no-empty-file.mjs b/test/no-empty-file.mjs
@@ -77,3 +77,13 @@ test.snapshot({
 		].map(extension => ({code: '{}', filename: `example.${extension}`})),
 	],
 });
+
+// Test for https://github.com/sindresorhus/eslint-plugin-unicorn/issues/2175
+test.typescript({
+	valid: [
+		{code: '(() => {})();', filename: 'example.ts'},
+	],
+	invalid: [
+		{code: '"";', filename: 'example.ts', errors: 1},
+	],
+});