prefer-module: Allow module as TSTypeParameter name (#2213)

Co-authored-by: fisker Cheung <lionkay@gmail.com>
sindresorhus · Nov 27, 2023 · 8f61f7c · 8f61f7c
1 parent b95e75e
commit 8f61f7c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/rules/ast/is-reference-identifier.js b/rules/ast/is-reference-identifier.js
@@ -120,6 +120,11 @@ function isNotReference(node) {
 			return parent.parameters.includes(node);
 		}
 
+		// `type Foo = { [Identifier in keyof string]: number; };`
+		case 'TSTypeParameter': {
+			return parent.name === node;
+		}
+
 		// `type Identifier = Foo`
 		case 'TSTypeAliasDeclaration': {
 			return parent.id === node;

diff --git a/test/prefer-module.mjs b/test/prefer-module.mjs
@@ -272,6 +272,7 @@ test.typescript({
 		'type ModuleRegistry = { [module: string]: string };',
 		'const module = 1; type ModuleRegistry = { [module: string]: string };',
 		'type module = number[]; type ModuleRegistry = { [module: string]: string };',
+		'type Data = { [module in keyof string]: number; };',
 		'type ModuleRegistry = { [exports: string]: string };',
 	],
 	invalid: [],