Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer-array-some: ignore filter calls with literal argument #2097

Merged
merged 6 commits into from
May 15, 2023
Merged

prefer-array-some: ignore filter calls with literal argument #2097

merged 6 commits into from
May 15, 2023

Conversation

thorn0
Copy link
Contributor

@thorn0 thorn0 commented May 14, 2023

No description provided.

@fisker
Copy link
Collaborator

fisker commented May 15, 2023

There is a function isNodeValueNotFunction

eslint-plugin-unicorn/rules/utils/index.js

Line 4 in 7895e5d

isNodeValueNotFunction: require('./is-node-value-not-function.js'),

Let's use it.

fisker
fisker approved these changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@fisker fisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sindresorhus sindresorhus merged commit 7a32edb into sindresorhus:main May 15, 2023
@thorn0 thorn0 deleted the jquery-filter branch May 15, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisker fisker fisker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thorn0 @fisker @sindresorhus