[BREAKING] for consistency return a result object from execa.sync() instead of string - fixes #19
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestalmage
changed the title
jamestalmage
force-pushed
the
consistent-sync-return
branch
from
3acc178
to
03c45b6
Compare
|
Nevermind - there were no conflicts between this and #18 (rebase drop went without a hitch). Merge either/both at will. |
sindresorhus
changed the title
execa.sync() instead of string for consistency - fixes #19
sindresorhus
changed the title
execa.sync() instead of string for consistency - fixes #19execa.sync() instead of string, for consistency - fixes #19
sindresorhus
changed the title
execa.sync() instead of string, for consistency - fixes #19execa.sync() instead of string - fixes #19
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes commits from #18, so avoid merging until after that is, and I can rebase.