Re-enable Windows in CI #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
force-pushed
the
chore/ci-windows
branch
4 times, most recently
from
ec48728 to
d33cf55
Compare
ehmicky
commented
May 17, 2022
|
|
||
| process.env.PATH = fileURLToPath(new URL('fixtures', import.meta.url)) + path.delimiter + process.env.PATH; | ||
| setFixtureDir(); |
There was a problem hiding this comment.
How the PATH/Path environment variable in the GitHub actions Windows environment seems to have changed, making the CI tests fail. In particular, its name is now Path instead of PATH.
Using path-key fixes this. I put this as a shared helper to avoid code duplication.
ehmicky
commented
May 17, 2022
| }); | ||
|
|
||
| test('preferLocal: false', async t => { | ||
| await t.throwsAsync(execa('ava', ['--version'], {preferLocal: false, env: {Path: '', PATH: ''}}), {message: ENOENT_REGEXP}); |
There was a problem hiding this comment.
I am not completely sure why, but this fixes those tests on Windows.
Filtering the .bin directories from the PATH variable seems more adequate than making it completely empty as well.
ehmicky
commented
May 17, 2022
| t.deepEqual(stdout.split('\n'), ['foo', 'bar']); | ||
| }); | ||
|
|
||
| test('do not extend environment with `extendEnv: false`', async t => { | ||
| const {stdout} = await execa('environment.js', [], {env: {BAR: 'bar', PATH: process.env.PATH}, extendEnv: false}); | ||
| const {stdout} = await execa('environment.js', [], {env: {BAR: 'bar', [PATH_KEY]: process.env[PATH_KEY]}, extendEnv: false}); |
There was a problem hiding this comment.
This fixes the tests on Windows.
|
Good investigation 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the tests on Windows CI, and re-enables it. 🎉